Clamp AudioBuffer float to int{16,32} conversion

media/base/audio_bus.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/audio_bus.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <limits>
 
 #include "base/logging.h"
 #include "base/numerics/safe_conversions.h"
 #include "media/audio/audio_parameters.h"
+#include "media/base/audio_sample_conversion.h"
 #include "media/base/limits.h"
 #include "media/base/vector_math.h"
 
 namespace media {
 
-static const uint8_t kUint8Bias = 128;
-
 static bool IsAligned(void* ptr) {
   return (reinterpret_cast<uintptr_t>(ptr) &
           (AudioBus::kChannelAlignment - 1)) == 0U;
 }
 
 // Calculates the required size for an AudioBus with the given params, sets
 // |aligned_frames| to the actual frame length of each channel array.
 static int CalculateMemorySizeInternal(int channels, int frames,
                                        int* out_aligned_frames) {
   // Choose a size such that each channel will be aligned by
   // kChannelAlignment when stored in a contiguous block.
   int aligned_frames =
       ((frames * sizeof(float) + AudioBus::kChannelAlignment - 1) &
        ~(AudioBus::kChannelAlignment - 1)) / sizeof(float);
 
   if (out_aligned_frames)
     *out_aligned_frames = aligned_frames;
 
   return sizeof(float) * channels * aligned_frames;
 }
 
-// |Format| is the destination type.  If a bias is present, |Fixed| must be a
-// type larger than |Format| such that operations can be made without
-// overflowing.  Without a bias |Fixed| must be the same as |Format|.
-template<class Format, class Fixed, Format Bias>
-static void FromInterleavedInternal(const void* src, int start_frame,
-                                    int frames, AudioBus* dest,
-                                    float min, float max) {
-  static_assert((Bias == 0 && sizeof(Fixed) == sizeof(Format)) ||
-                sizeof(Fixed) > sizeof(Format), "invalid deinterleave types");
+template <class Format>
+static void FromInterleavedInternal(const void* src,
+                                    int start_frame,
+                                    int frames,
+                                    AudioBus* dest) {
   const Format* source = static_cast<const Format*>(src);
   const int channels = dest->channels();
   for (int ch = 0; ch < channels; ++ch) {
-    float* channel_data = dest->channel(ch);
-    for (int i = start_frame, offset = ch; i < start_frame + frames;
-         ++i, offset += channels) {
-      const Fixed v = static_cast<Fixed>(source[offset]) - Bias;
-      channel_data[i] = v * (v < 0 ? -min : max);
-    }
+    DeinterleaveOneChannel(source, start_frame, frames, dest->channel(ch),
+                           channels, ch);
   }
 }
 
-// |Format| is the destination type.  If a bias is present, |Fixed| must be a
-// type larger than |Format| such that operations can be made without
-// overflowing.  Without a bias |Fixed| must be the same as |Format|.
-template<class Format, class Fixed, Format Bias>
-static void ToInterleavedInternal(const AudioBus* source, int start_frame,
-                                  int frames, void* dst, Fixed min, Fixed max) {
-  static_assert((Bias == 0 && sizeof(Fixed) == sizeof(Format)) ||
-                sizeof(Fixed) > sizeof(Format), "invalid interleave types");
+template <class Format>
+static void ToInterleavedInternal(const AudioBus* source,
+                                  int start_frame,
+                                  int frames,
+                                  void* dst) {
   Format* dest = static_cast<Format*>(dst);
   const int channels = source->channels();
   for (int ch = 0; ch < channels; ++ch) {
-    const float* channel_data = source->channel(ch);
-    for (int i = start_frame, offset = ch; i < start_frame + frames;
-         ++i, offset += channels) {
-      const float v = channel_data[i];
-
-      Fixed sample;
-      if (v < 0)
-        sample = v <= -1 ? min : static_cast<Fixed>(-v * min);
-      else
-        sample = v >= 1 ? max : static_cast<Fixed>(v * max);
-
-      dest[offset] = static_cast<Format>(sample) + Bias;
-    }
+    InterleaveOneChannel(source->channel(ch), start_frame, frames, dest,
+                         channels, ch);
   }
 }
 
 static void ValidateConfig(int channels, int frames) {
   CHECK_GT(frames, 0);
   CHECK_GT(channels, 0);
   CHECK_LE(channels, static_cast<int>(limits::kMaxChannels));
 }
 
 static void CheckOverflow(int start_frame, int frames, int total_frames) {
@@ skipping 152 matching lines @@
   for (int i = 0; i < channels; ++i)
     channel_data_.push_back(data + i * aligned_frames);
 }
 
 // TODO(dalecurtis): See if intrinsic optimizations help any here.
 void AudioBus::FromInterleavedPartial(const void* source, int start_frame,
                                       int frames, int bytes_per_sample) {
   CheckOverflow(start_frame, frames, frames_);
   switch (bytes_per_sample) {
     case 1:
-      FromInterleavedInternal<uint8_t, int16_t, kUint8Bias>(
-          source, start_frame, frames, this,
-          1.0f / std::numeric_limits<int8_t>::min(),
-          1.0f / std::numeric_limits<int8_t>::max());
+      FromInterleavedInternal<uint8_t>(source, start_frame, frames, this);
       break;
     case 2:
-      FromInterleavedInternal<int16_t, int16_t, 0>(
-          source, start_frame, frames, this,
-          1.0f / std::numeric_limits<int16_t>::min(),
-          1.0f / std::numeric_limits<int16_t>::max());
+      FromInterleavedInternal<int16_t>(source, start_frame, frames, this);
       break;
     case 4:
-      FromInterleavedInternal<int32_t, int32_t, 0>(
-          source, start_frame, frames, this,
-          1.0f / std::numeric_limits<int32_t>::min(),
-          1.0f / std::numeric_limits<int32_t>::max());
+      FromInterleavedInternal<int32_t>(source, start_frame, frames, this);
       break;
     default:
       NOTREACHED() << "Unsupported bytes per sample encountered.";
       ZeroFramesPartial(start_frame, frames);
       return;
   }
 
   // Don't clear remaining frames if this is a partial deinterleave.
   if (!start_frame) {
     // Zero any remaining frames.
@@ skipping 10 matching lines @@
                              void* dest) const {
   ToInterleavedPartial(0, frames, bytes_per_sample, dest);
 }
 
 // TODO(dalecurtis): See if intrinsic optimizations help any here.
 void AudioBus::ToInterleavedPartial(int start_frame, int frames,
                                     int bytes_per_sample, void* dest) const {
   CheckOverflow(start_frame, frames, frames_);
   switch (bytes_per_sample) {
     case 1:
-      ToInterleavedInternal<uint8_t, int16_t, kUint8Bias>(
-          this, start_frame, frames, dest, std::numeric_limits<int8_t>::min(),
-          std::numeric_limits<int8_t>::max());
+      ToInterleavedInternal<uint8_t>(this, start_frame, frames, dest);
       break;
     case 2:
-      ToInterleavedInternal<int16_t, int16_t, 0>(
-          this, start_frame, frames, dest, std::numeric_limits<int16_t>::min(),
-          std::numeric_limits<int16_t>::max());
+      ToInterleavedInternal<int16_t>(this, start_frame, frames, dest);
       break;
     case 4:
-      ToInterleavedInternal<int32_t, int32_t, 0>(
-          this, start_frame, frames, dest, std::numeric_limits<int32_t>::min(),
-          std::numeric_limits<int32_t>::max());
+      ToInterleavedInternal<int32_t>(this, start_frame, frames, dest);
       break;
     default:
       NOTREACHED() << "Unsupported bytes per sample encountered.";
       memset(dest, 0, frames * bytes_per_sample);
       return;
   }
 }
 
 void AudioBus::CopyTo(AudioBus* dest) const {
   CopyPartialFramesTo(0, frames(), 0, dest);
@@ skipping 37 matching lines @@
   return scoped_refptr<AudioBusRefCounted>(
       new AudioBusRefCounted(channels, frames));
 }
 
 AudioBusRefCounted::AudioBusRefCounted(int channels, int frames)
     : AudioBus(channels, frames) {}
 
 AudioBusRefCounted::~AudioBusRefCounted() {}
 
 }  // namespace media