Remove DisplayCount from GpuDataManagerImpl.

Remove DisplayCount from GpuDataManagerImpl.

This was used for the MSAA blacklist, but which had no effect and was
now removed, so the variable is unused.

R=piman@chomium.org
BUG=599721, 584497
Committed: https://crrev.com/5fd131d69d33b19d44b9b251d3f062b6daef3b5c
Cr-Commit-Position: refs/heads/master@{#385250}

[danakj, 2016-04-05 00:51:03]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 00:51:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854383002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854383002/1

[danakj, 2016-04-05 00:51:57]

https://codereview.chromium.org/1854383002/diff/1/content/browser/gpu/gpu_dat...
File content/browser/gpu/gpu_data_manager_impl_private.cc (left):

https://codereview.chromium.org/1854383002/diff/1/content/browser/gpu/gpu_dat...
content/browser/gpu/gpu_data_manager_impl_private.cc:247:
manager->HandleGpuSwitch();
Uhh, maybe this is still needed.. oops.

[danakj, 2016-04-05 00:57:52]

https://codereview.chromium.org/1854383002/diff/1/content/browser/gpu/gpu_dat...
File content/browser/gpu/gpu_data_manager_impl_private.cc (left):

https://codereview.chromium.org/1854383002/diff/1/content/browser/gpu/gpu_dat...
content/browser/gpu/gpu_data_manager_impl_private.cc:247:
manager->HandleGpuSwitch();
On 2016/04/05 00:51:57, danakj wrote:
> Uhh, maybe this is still needed.. oops.

HandleGpuSwitch() calls GpuSwitchingManager::NotifyGpuSwitched() and sends
GpuMsg_GpuSwitched to the GPU process.

NotifyGpuSwitched() was used to update WebPreferences in the browser process.

But other observers are:
- GpuMessageHandler::OnGpuSwitched() which calls
GpuDataManagerImpl::RequestCompleteGpuInfoIfNeeded();

uhh.. well that one is a complete circle, we were coming from the
GpuDataManagerImpl already.

I'm not actually seeing any overrides of OnGpuSwitched in the gpu process. Maybe
on other OSes that codesearch doesn't index.

[danakj, 2016-04-05 01:00:15]

https://codereview.chromium.org/1854383002/diff/1/content/browser/gpu/gpu_dat...
File content/browser/gpu/gpu_data_manager_impl_private.cc (left):

https://codereview.chromium.org/1854383002/diff/1/content/browser/gpu/gpu_dat...
content/browser/gpu/gpu_data_manager_impl_private.cc:247:
manager->HandleGpuSwitch();
On 2016/04/05 00:57:52, danakj wrote:
> On 2016/04/05 00:51:57, danakj wrote:
> > Uhh, maybe this is still needed.. oops.
> 
> HandleGpuSwitch() calls GpuSwitchingManager::NotifyGpuSwitched() and sends
> GpuMsg_GpuSwitched to the GPU process.
> 
> NotifyGpuSwitched() was used to update WebPreferences in the browser process.
> 
> But other observers are:
> - GpuMessageHandler::OnGpuSwitched() which calls
> GpuDataManagerImpl::RequestCompleteGpuInfoIfNeeded();
> 
> uhh.. well that one is a complete circle, we were coming from the
> GpuDataManagerImpl already.
> 
> I'm not actually seeing any overrides of OnGpuSwitched in the gpu process.
Maybe
> on other OSes that codesearch doesn't index.

Ok ya on MacOSX there are some more..

- ImageTransportSurfaceOverlayMac::OnGpuSwitched() which creates a new context.

- IOSurfaceContext::OnGpuSwitched() which poisons itself and its share group.

[danakj, 2016-04-05 01:01:03]

https://codereview.chromium.org/1854383002/diff/20001/content/browser/gpu/gpu...
File content/browser/gpu/gpu_data_manager_impl_private.cc (left):

https://codereview.chromium.org/1854383002/diff/20001/content/browser/gpu/gpu...
content/browser/gpu/gpu_data_manager_impl_private.cc:218: void
DisplayReconfigCallback(CGDirectDisplayID display,
Restored this.

[danakj, 2016-04-05 01:01:15]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 01:01:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854383002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854383002/20001

[Ken Russell (switch to Gerrit), 2016-04-05 01:40:45]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-04-05 01:40:46]

lgtm fwiw.

[commit-bot: I haz the power, 2016-04-05 07:08:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 07:08:22]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_TIMED_OUT,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[danakj, 2016-04-05 18:15:27]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-04-05 18:16:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854383002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854383002/20001

[commit-bot: I haz the power, 2016-04-05 19:18:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-05 19:20:35]

Description was changed from

==========
Remove DisplayCount from GpuDataManagerImpl.

This was used for the MSAA blacklist, but which had no effect and was
now removed, so the variable is unused.

R=piman@chomium.org
BUG=599721, 584497
==========

to

==========
Remove DisplayCount from GpuDataManagerImpl.

This was used for the MSAA blacklist, but which had no effect and was
now removed, so the variable is unused.

R=piman@chomium.org
BUG=599721, 584497

Committed: https://crrev.com/5fd131d69d33b19d44b9b251d3f062b6daef3b5c
Cr-Commit-Position: refs/heads/master@{#385250}
==========

[commit-bot: I haz the power, 2016-04-05 19:20:36]

Patchset 2 (id:??) landed as
https://crrev.com/5fd131d69d33b19d44b9b251d3f062b6daef3b5c
Cr-Commit-Position: refs/heads/master@{#385250}