Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1854303003: MD Settings: Fix <settings-dialog> resizing behavior. (Closed)

Created:
4 years, 8 months ago by dpapad
Modified:
4 years, 8 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix <settings-dialog> resizing behavior. BUG=598038 Committed: https://crrev.com/dbaf5751a78280239672ca9ee212d1234ceea894 Cr-Commit-Position: refs/heads/master@{#385211}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/settings/settings_dialog.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dpapad
Before screenshot: see bug. After screenshot: http://imgur.com/nqE404k.
4 years, 8 months ago (2016-04-05 01:27:52 UTC) #2
Dan Beam
lgtm
4 years, 8 months ago (2016-04-05 01:33:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854303003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854303003/1
4 years, 8 months ago (2016-04-05 16:51:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 17:35:47 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 17:37:18 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dbaf5751a78280239672ca9ee212d1234ceea894
Cr-Commit-Position: refs/heads/master@{#385211}

Powered by Google App Engine
This is Rietveld 408576698