Plurals and Genders

pkg/intl/lib/generate_localized.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * This provides utilities for generating localized versions of
  * messages. It does not stand alone, but expects to be given
  * TranslatedMessage objects and generate code for a particular locale
  * based on them.
  *
@@ skipping 43 matching lines @@
 
 /**
  * This represents a message and its translation. We assume that the translation
  * has some identifier that allows us to figure out the original message it
  * corresponds to, and that it may want to transform the translated text in
  * some way, e.g. to turn whatever format the translation uses for variables
  * into a Dart string interpolation. Specific translation
  * mechanisms are expected to subclass this.
  */
 abstract class TranslatedMessage {
-  /** The identifier for this message. In the simplest case, this is the name.*/
-  var id;
+  /**
+   * The identifier for this message. In the simplest case, this is the name,

[Emily Fortuna, 2013/07/03 17:52:33]

sorry, name of what?

[Alan Knight, 2013/07/03 18:41:07]

Clarified.

+   * but it can be any identifier that this program and the output of the
+   * translation can agree on as identifying a message.
+   */
+  String id;
 
-  String translatedString;
-  IntlMessage originalMessage;
-  TranslatedMessage(this.id, this.translatedString);
+  /** Our translated version of [originalMessage]. */
+  Message translated;
 
-  String get message => translatedString;
+  /** The original message that we are a translation of. */
+  MainMessage originalMessage;
+
+  TranslatedMessage(this.id, this.translated);
+
+  get message => translated;

[Emily Fortuna, 2013/07/03 17:52:33]

I think we prefer to still have return types, especially for APIs that others
will use.

[Alan Knight, 2013/07/03 18:41:07]

There should be very few others using these APIs, but done.

+
+  toString() => id.toString();
 }
 
 /**
  * We can't use a hyphen in a Dart library name, so convert the locale
  * separator to an underscore.
  */
 String asLibraryName(String x) => x.replaceAll('-', '_');
 
 /**
- * Generate a file messages_<locale>.dart for the [translations] in
- * [locale].
+ * Generate a file <[generated_file_prefix]>_messages_<[locale]>.dart
+ * for the [translations] in [locale] and put it in [targetDir].
  */
 void generateIndividualMessageFile(String locale,
     Iterable<TranslatedMessage> translations, String targetDir) {
   var result = new StringBuffer();
-  locale = new IntlMessage().escapeAndValidate(locale, locale);
+  locale = new MainMessage().escapeAndValidateString(locale);
   result.write(prologue(locale));
   // Exclude messages with no translation and translations with no matching
   // original message (e.g. if we're using some messages from a larger catalog)
   var usableTranslations =  translations.where(
       (each) => each.originalMessage != null && each.message != null).toList();
   for (var each in usableTranslations) {
       each.originalMessage.addTranslation(locale, each.message);
   }
   usableTranslations.sort((a, b) =>
       a.originalMessage.name.compareTo(b.originalMessage.name));
-  for (var each in usableTranslations) {
+  for (var translation in usableTranslations) {
     result.write("  ");
-    result.write(each.originalMessage.toCode(locale));
+    result.write(translation.originalMessage.toCodeForLocale(locale));
     result.write("\n\n");
   }
   result.write("\n  final messages = const {\n");
   var entries = usableTranslations
       .map((translation) => translation.originalMessage.name)
       .map((name) => "    \"$name\" : $name");
   result.write(entries.join(",\n"));
   result.write("\n  };\n}");
 
   var output = new File(path.join(targetDir,
@@ skipping 82 matching lines @@
   messageLookup.addLocale(localeName, _findGeneratedMessagesFor);
   return new Future.value();
 }
 
 MessageLookupByLibrary _findGeneratedMessagesFor(locale) {
   var actualLocale = Intl.verifiedLocale(locale, (x) => _findExact(x) != null);
   if (actualLocale == null) return null;
   return _findExact(actualLocale);
 }
 """;