Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: src/gpu/gl/GrGLCaps.cpp

Issue 1854283004: Track GL buffer state based on unique resource ID (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: fix for GR_GL_USE_BUFFER_DATA_NULL_HINT=0 Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/gpu/gl/GrGLBuffer.cpp ('k') | src/gpu/gl/GrGLGpu.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 Google Inc. 2 * Copyright 2012 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 8
9 #include "GrGLCaps.h" 9 #include "GrGLCaps.h"
10 10
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 } 129 }
130 } 130 }
131 fImagingSupport = kGL_GrGLStandard == standard && 131 fImagingSupport = kGL_GrGLStandard == standard &&
132 ctxInfo.hasExtension("GL_ARB_imaging"); 132 ctxInfo.hasExtension("GL_ARB_imaging");
133 133
134 // SGX and Mali GPUs that are based on a tiled-deferred architecture that ha ve trouble with 134 // SGX and Mali GPUs that are based on a tiled-deferred architecture that ha ve trouble with
135 // frequently changing VBOs. We've measured a performance increase using non -VBO vertex 135 // frequently changing VBOs. We've measured a performance increase using non -VBO vertex
136 // data for dynamic content on these GPUs. Perhaps we should read the render er string and 136 // data for dynamic content on these GPUs. Perhaps we should read the render er string and
137 // limit this decision to specific GPU families rather than basing it on the vendor alone. 137 // limit this decision to specific GPU families rather than basing it on the vendor alone.
138 if (!GR_GL_MUST_USE_VBO && 138 if (!GR_GL_MUST_USE_VBO &&
139 !fIsCoreProfile &&
139 (kARM_GrGLVendor == ctxInfo.vendor() || 140 (kARM_GrGLVendor == ctxInfo.vendor() ||
140 kImagination_GrGLVendor == ctxInfo.vendor() || 141 kImagination_GrGLVendor == ctxInfo.vendor() ||
141 kQualcomm_GrGLVendor == ctxInfo.vendor())) { 142 kQualcomm_GrGLVendor == ctxInfo.vendor())) {
142 fUseNonVBOVertexAndIndexDynamicData = true; 143 fUseNonVBOVertexAndIndexDynamicData = true;
143 } 144 }
144 145
145 // A driver but on the nexus 6 causes incorrect dst copies when invalidate i s called beforehand. 146 // A driver but on the nexus 6 causes incorrect dst copies when invalidate i s called beforehand.
146 // Thus we are blacklisting this extension for now on Adreno4xx devices. 147 // Thus we are blacklisting this extension for now on Adreno4xx devices.
147 if (kAdreno4xx_GrGLRenderer != ctxInfo.renderer() && 148 if (kAdreno4xx_GrGLRenderer != ctxInfo.renderer() &&
148 ((kGL_GrGLStandard == standard && version >= GR_GL_VER(4,3)) || 149 ((kGL_GrGLStandard == standard && version >= GR_GL_VER(4,3)) ||
(...skipping 1724 matching lines...) Expand 10 before | Expand all | Expand 10 after
1873 for (int j = 0; j < kExternalFormatUsageCnt; ++j) { 1874 for (int j = 0; j < kExternalFormatUsageCnt; ++j) {
1874 SkASSERT(defaultEntry.fFormats.fExternalFormat[j] != 1875 SkASSERT(defaultEntry.fFormats.fExternalFormat[j] !=
1875 fConfigTable[i].fFormats.fExternalFormat[j]); 1876 fConfigTable[i].fFormats.fExternalFormat[j]);
1876 } 1877 }
1877 SkASSERT(defaultEntry.fFormats.fExternalType != fConfigTable[i].fFormats .fExternalType); 1878 SkASSERT(defaultEntry.fFormats.fExternalType != fConfigTable[i].fFormats .fExternalType);
1878 } 1879 }
1879 #endif 1880 #endif
1880 } 1881 }
1881 1882
1882 void GrGLCaps::onApplyOptionsOverrides(const GrContextOptions& options) {} 1883 void GrGLCaps::onApplyOptionsOverrides(const GrContextOptions& options) {}
OLDNEW
« no previous file with comments | « src/gpu/gl/GrGLBuffer.cpp ('k') | src/gpu/gl/GrGLGpu.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698