Remove the non-RFC 7539 variants of ChaCha20Poly1305 crypters in QUIC

Remove the non-RFC 7539 variants of ChaCha20Poly1305 crypters in QUIC
since the RFC 7539 variants are now enabled in Chrome stable.

R=davidben@chromium.org
BUG=

Committed: https://crrev.com/75a87551310ed3c285b697b98f20cb17f9d73050
Cr-Commit-Position: refs/heads/master@{#385140}

[Ryan Hamilton, 2016-04-04 19:50:03]

Patchset #1 (id:1) has been deleted

[Ryan Hamilton, 2016-04-04 19:50:09]

Patchset #1 (id:20001) has been deleted

[Ryan Hamilton, 2016-04-04 19:50:14]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 19:50:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854273002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854273002/40001

[commit-bot: I haz the power, 2016-04-04 19:57:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 19:57:55]

Dry run: Try jobs failed on following builders:
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)

[davidben, 2016-04-04 20:22:39]

Just a bit of buildsystem silliness.

https://codereview.chromium.org/1854273002/diff/40001/net/BUILD.gn
File net/BUILD.gn (left):

https://codereview.chromium.org/1854273002/diff/40001/net/BUILD.gn#oldcode167
net/BUILD.gn:167: "quic/crypto/chacha20_poly1305_encrypter_nss.cc",
Similar change in net_common.gypi?

https://codereview.chromium.org/1854273002/diff/40001/net/BUILD.gn
File net/BUILD.gn (right):

https://codereview.chromium.org/1854273002/diff/40001/net/BUILD.gn#newcode197
net/BUILD.gn:197: "quic/crypto/chacha20_poly1305_encrypter_openssl.cc",
iOS is unhappy you haven't removed these two lines. Ditto in net_common.gypi I
expect.

https://codereview.chromium.org/1854273002/diff/40001/net/quic/crypto/crypto_...
File net/quic/crypto/crypto_protocol.h (left):

https://codereview.chromium.org/1854273002/diff/40001/net/quic/crypto/crypto_...
net/quic/crypto/crypto_protocol.h:51: const QuicTag kCC20 = TAG('C', 'C', '2',
'0');   // ChaCha20 + Poly1305 RFC7539
(Probably for a follow-up, but I'd suggest getting rid of all the RFC7539
suffixes now that the old one doesn't exist.)

[Ryan Hamilton, 2016-04-04 20:34:12]

Thanks!

https://codereview.chromium.org/1854273002/diff/40001/net/BUILD.gn
File net/BUILD.gn (left):

https://codereview.chromium.org/1854273002/diff/40001/net/BUILD.gn#oldcode167
net/BUILD.gn:167: "quic/crypto/chacha20_poly1305_encrypter_nss.cc",
On 2016/04/04 20:22:39, davidben (OOO 4-4 to 4-11) wrote:
> Similar change in net_common.gypi?

Done!

https://codereview.chromium.org/1854273002/diff/40001/net/BUILD.gn
File net/BUILD.gn (right):

https://codereview.chromium.org/1854273002/diff/40001/net/BUILD.gn#newcode197
net/BUILD.gn:197: "quic/crypto/chacha20_poly1305_encrypter_openssl.cc",
On 2016/04/04 20:22:39, davidben (OOO 4-4 to 4-11) wrote:
> iOS is unhappy you haven't removed these two lines. Ditto in net_common.gypi I
> expect.

Thanks! Done.

https://codereview.chromium.org/1854273002/diff/40001/net/quic/crypto/crypto_...
File net/quic/crypto/crypto_protocol.h (left):

https://codereview.chromium.org/1854273002/diff/40001/net/quic/crypto/crypto_...
net/quic/crypto/crypto_protocol.h:51: const QuicTag kCC20 = TAG('C', 'C', '2',
'0');   // ChaCha20 + Poly1305 RFC7539
On 2016/04/04 20:22:39, davidben (OOO 4-4 to 4-11) wrote:
> (Probably for a follow-up, but I'd suggest getting rid of all the RFC7539
> suffixes now that the old one doesn't exist.)

Totally will do so after all this sorts itself out. Doing the rename and the
delete will likely confuse git history. :/

[davidben, 2016-04-04 21:22:53]

lgtm

[Ryan Hamilton, 2016-04-04 21:23:42]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2016-04-04 21:24:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854273002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854273002/60001

[commit-bot: I haz the power, 2016-04-04 22:31:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 22:31:02]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Ryan Hamilton, 2016-04-04 23:12:00]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 23:12:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854273002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854273002/80001

[Ryan Hamilton, 2016-04-05 00:24:20]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 00:25:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854273002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854273002/100001

[commit-bot: I haz the power, 2016-04-05 00:32:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 00:32:26]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Ryan Hamilton, 2016-04-05 02:22:41]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2016-04-05 02:22:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
davidben@chromium.org
Link to the patchset: https://codereview.chromium.org/1854273002/#ps120001
(title: "include")

[commit-bot: I haz the power, 2016-04-05 02:23:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854273002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854273002/120001

[Ryan Sleevi, 2016-04-05 04:44:50]

rsleevi@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Ryan Sleevi, 2016-04-05 04:44:50]

Note: In the future, it'd be good to have a BUG to staple these changes to,
especially when they result in observable behaviour :)

[commit-bot: I haz the power, 2016-04-05 06:47:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 06:47:25]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_TIMED_OUT,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ryan Sleevi, 2016-04-05 08:13:42]

The CQ bit was checked by rsleevi@chromium.org

[commit-bot: I haz the power, 2016-04-05 08:14:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854273002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854273002/120001

[commit-bot: I haz the power, 2016-04-05 09:20:39]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2016-04-05 09:22:04]

Description was changed from

==========
Remove the non-RFC 7539 variants of ChaCha20Poly1305 crypters in QUIC
since the RFC 7539 variants are now enabled in Chrome stable.

R=davidben@chromium.org
BUG=
==========

to

==========
Remove the non-RFC 7539 variants of ChaCha20Poly1305 crypters in QUIC
since the RFC 7539 variants are now enabled in Chrome stable.

R=davidben@chromium.org
BUG=

Committed: https://crrev.com/75a87551310ed3c285b697b98f20cb17f9d73050
Cr-Commit-Position: refs/heads/master@{#385140}
==========

[commit-bot: I haz the power, 2016-04-05 09:22:05]

Patchset 5 (id:??) landed as
https://crrev.com/75a87551310ed3c285b697b98f20cb17f9d73050
Cr-Commit-Position: refs/heads/master@{#385140}