Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1854253002: Disable document mode. (Closed)

Created:
4 years, 8 months ago by gone
Modified:
4 years, 8 months ago
Reviewers:
Ted C
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable document mode. * Removes the need for a command line flag to automatically migrate users to tabbed mode. * Document mode code is kept in the repo, but there shouldn't be any way for the user to open new DocumentActivities. * Disables all Document mode related tests _that start up Chrome_. DocumentTabModelImplTests, for example, still run because they don't start up Chrome. BUG=582539 Committed: https://crrev.com/7b54c0e18c5e8b8b180c95d067797e36a23301db Cr-Commit-Position: refs/heads/master@{#384997}

Patch Set 1 #

Patch Set 2 : Cleaning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -111 lines) Patch
M chrome/android/java/res/xml/main_preferences.xml View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/EmbedContentViewActivity.java View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java View 3 chunks +0 lines, -19 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java View 3 chunks +1 line, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java View 1 4 chunks +4 lines, -27 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java View 3 chunks +0 lines, -26 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerInDocumentModeIntegrationTest.java View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeLowEndTest.java View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeReferrerTest.java View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTest.java View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/hardware_acceleration/DocumentActivityHWATest.java View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ntp/DocumentModeRecentlyClosedTest.java View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
gone
4 years, 8 months ago (2016-04-04 19:37:07 UTC) #2
Ted C
lgtm
4 years, 8 months ago (2016-04-04 20:21:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854253002/20001
4 years, 8 months ago (2016-04-04 20:25:54 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-04 20:45:02 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 20:46:17 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b54c0e18c5e8b8b180c95d067797e36a23301db
Cr-Commit-Position: refs/heads/master@{#384997}

Powered by Google App Engine
This is Rietveld 408576698