Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: runtime/vm/service.cc

Issue 1854243002: VM: Evaluate-in-frame should happen in the scope of the method class, not the receiver class. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index 0caeb9c872e8dc3efeebf044a3ed0c1de6aff079..62048e0fd3b5db95a5b9415dcf05e37de591e981 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -2150,8 +2150,10 @@ static bool Evaluate(Thread* thread, JSONStream* js) {
// We don't use Instance::Cast here because it doesn't allow null.
Instance& instance = Instance::Handle(zone);
instance ^= obj.raw();
+ const Class& receiver_cls = Class::Handle(zone, instance.clazz());
const Object& result =
- Object::Handle(zone, instance.Evaluate(expr_str,
+ Object::Handle(zone, instance.Evaluate(receiver_cls,
+ expr_str,
Array::empty_array(),
Array::empty_array()));
result.PrintJSON(js, true);
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698