runtime/vm/debugger_api_impl.cc - Issue 1854243002: VM: Evaluate-in-frame should happen in the scope of the method class, not the receiver class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/debugger_api_impl.cc

Issue 1854243002: VM: Evaluate-in-frame should happen in the scope of the method class, not the receiver class. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/debugger_api_impl.cc

diff --git a/runtime/vm/debugger_api_impl.cc b/runtime/vm/debugger_api_impl.cc

index 829f0f5c12d9f73c8b3b075b5f1d238aaee9fe4b..f98b60a12df313d834544583d3a764d210e78637 100644

--- a/runtime/vm/debugger_api_impl.cc

+++ b/runtime/vm/debugger_api_impl.cc

@@ -568,7 +568,9 @@ DART_EXPORT Dart_Handle Dart_EvaluateExpr(Dart_Handle target_in,

Array::empty_array()));

} else if (target.IsInstance()) {

const Instance& inst = Instance::Cast(target);

- return Api::NewHandle(T, inst.Evaluate(expr,

+ const Class& receiver_cls = Class::Handle(Z, inst.clazz());

+ return Api::NewHandle(T, inst.Evaluate(receiver_cls,

+ expr,

Array::empty_array(),

Array::empty_array()));

} else if (target.IsLibrary()) {

« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »