Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: runtime/vm/object.cc

Issue 1854243002: VM: Evaluate-in-frame should happen in the scope of the method class, not the receiver class. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index 9afe3fc37ceb3d49ad4d77fb5437a277ac0761c4..c8a483f399a72a7d1fd15382a045234ce2274e74 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -14555,12 +14555,12 @@ const char* UnwindError::ToCString() const {
}
-RawObject* Instance::Evaluate(const String& expr,
+RawObject* Instance::Evaluate(const Class& method_cls,
+ const String& expr,
const Array& param_names,
const Array& param_values) const {
- const Class& cls = Class::Handle(clazz());
const Function& eval_func =
- Function::Handle(EvaluateHelper(cls, expr, param_names, false));
+ Function::Handle(EvaluateHelper(method_cls, expr, param_names, false));
const Array& args = Array::Handle(Array::New(1 + param_values.Length()));
PassiveObject& param = PassiveObject::Handle();
args.SetAt(0, *this);
« runtime/vm/debugger.cc ('K') | « runtime/vm/object.h ('k') | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698