Oilpan: Fix crashes in ~CSSGroupingRule()

Oilpan: Fix crashes in ~CSSGroupingRule()

We observe crashes in fast/dom/css-delete-doc.html.
The cause is that ~CSSGroupingRule() touches m_childRuleCSSOMWrappers.
~CSSGroupingRule() shouldn't touch m_childRuleCSSOMWrappers because the wrappers are on the heap.

NOTRY=true
R=ager@chromium.org, wibling@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168374

[haraken, 2014-03-04 06:13:42]

PTAL

[kouhei (in TOK), 2014-03-04 06:15:01]

On 2014/03/04 06:13:42, haraken wrote:
> PTAL

lgtm.

[haraken, 2014-03-04 06:15:27]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-03-04 06:15:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/185423009/20001

[wibling-chromium, 2014-03-04 07:04:30]

lgtm

[Mads Ager (chromium), 2014-03-04 07:24:04]

LGTM

https://codereview.chromium.org/185423009/diff/20001/Source/core/css/CSSGroup...
File Source/core/css/CSSGroupingRule.cpp (right):

https://codereview.chromium.org/185423009/diff/20001/Source/core/css/CSSGroup...
Source/core/css/CSSGroupingRule.cpp:53: #if !ENABLE(OILPAN)
We need the same change in CSSKeyframesRule.cpp.

[haraken, 2014-03-04 09:37:56]

The CQ bit was unchecked by haraken@chromium.org

[haraken, 2014-03-04 09:38:05]

The CQ bit was checked by haraken@chromium.org

[Mads Ager (chromium), 2014-03-04 10:07:45]

Committed patchset #2 manually as r168374 (presubmit successful).

[Mads Ager (chromium), 2014-03-04 10:08:29]

I went ahead and landed this since it fixes crashes. The cq is not helping at
the moment. I'll watch the buildbots.