Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: base/os_compat_android.cc

Issue 185423006: Eliminate build warnings in base/ for Android x64 (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Fixed the style nits Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/os_compat_android.cc
===================================================================
--- base/os_compat_android.cc (revision 254431)
+++ base/os_compat_android.cc (working copy)
@@ -41,8 +41,8 @@
// We replicate the behaviour of timegm() when the result overflows time_t.
time_t timegm(struct tm* const t) {
// time_t is signed on Android.
- static const time_t kTimeMax = ~(1 << (sizeof(time_t) * CHAR_BIT - 1));
- static const time_t kTimeMin = (1 << (sizeof(time_t) * CHAR_BIT - 1));
+ static const time_t kTimeMax = ~(1L << (sizeof(time_t) * CHAR_BIT - 1));
+ static const time_t kTimeMin = (1L << (sizeof(time_t) * CHAR_BIT - 1));
time64_t result = timegm64(t);
if (result < kTimeMin || result > kTimeMax)
return -1;

Powered by Google App Engine
This is Rietveld 408576698