Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 185423006: Eliminate build warnings in base/ for Android x64 (Closed)

Created:
6 years, 9 months ago by Zhenyu Liang
Modified:
6 years, 9 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Eliminate build warnings in base/ for Android x64 This CL fixes format strings of printf and type conversions that cause compilation warnings while building Android x64. BUG=346626 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257942

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fixed the style nits #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M base/debug/proc_maps_linux.cc View 1 2 3 4 5 2 chunks +5 lines, -4 lines 0 comments Download
M base/debug/stack_trace_android.cc View 1 2 3 4 5 2 chunks +8 lines, -2 lines 0 comments Download
M base/os_compat_android.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M base/strings/string_piece_unittest.cc View 1 2 3 4 5 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 36 (0 generated)
Zhenyu Liang
6 years, 9 months ago (2014-03-03 09:01:48 UTC) #1
bulach
lgtm % nits, good stuff, thanks!! I'm not an owner, so: +mark for base/* OWNERs ...
6 years, 9 months ago (2014-03-03 09:15:41 UTC) #2
rmcilroy
lgtm with a nit (and +1 to bulach's comments). https://codereview.chromium.org/185423006/diff/1/base/debug/proc_maps_linux.cc File base/debug/proc_maps_linux.cc (right): https://codereview.chromium.org/185423006/diff/1/base/debug/proc_maps_linux.cc#newcode23 base/debug/proc_maps_linux.cc:23: ...
6 years, 9 months ago (2014-03-03 10:55:04 UTC) #3
Mark Mentovai
https://codereview.chromium.org/185423006/diff/20001/base/debug/proc_maps_linux.cc File base/debug/proc_maps_linux.cc (right): https://codereview.chromium.org/185423006/diff/20001/base/debug/proc_maps_linux.cc#newcode18 base/debug/proc_maps_linux.cc:18: // is incompatible with Bionic's stdint.h defining uintptr_t as ...
6 years, 9 months ago (2014-03-03 14:25:35 UTC) #4
Zhenyu Liang
In 32-bit mode, SCNxPTR is already defined as "x" in current NDK. In 64-bit mode, ...
6 years, 9 months ago (2014-03-04 08:25:37 UTC) #5
Zhenyu Liang
I had tried on my local machine. No warnings and errors while compiling proc_maps_linux.cc both ...
6 years, 9 months ago (2014-03-10 06:53:01 UTC) #6
Mark Mentovai
Zhenyu Liang wrote: > In 32-bit mode, SCNxPTR is already defined as "x" in current ...
6 years, 9 months ago (2014-03-10 14:02:09 UTC) #7
bulach
afaict it's still a problem in the NDK versions we use: third_party/android_tools/ndk/platforms((0582bdc...))$ git grep SCNxPTR ...
6 years, 9 months ago (2014-03-10 18:57:23 UTC) #8
Mark Mentovai
Yeah, I guess we need to use what Ross suggested.
6 years, 9 months ago (2014-03-10 19:03:06 UTC) #9
Zhenyu Liang
On 2014/03/10 19:03:06, Mark Mentovai wrote: > Yeah, I guess we need to use what ...
6 years, 9 months ago (2014-03-11 07:29:59 UTC) #10
bulach
lgtm (but Mark is the real OWNER), thanks!
6 years, 9 months ago (2014-03-11 10:59:34 UTC) #11
Mark Mentovai
LGTM
6 years, 9 months ago (2014-03-11 13:16:09 UTC) #12
Zhenyu Liang
The CQ bit was checked by zhenyu.liang@intel.com
6 years, 9 months ago (2014-03-12 07:49:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhenyu.liang@intel.com/185423006/80001
6 years, 9 months ago (2014-03-12 08:05:59 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 08:30:53 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 9 months ago (2014-03-12 08:30:53 UTC) #16
Zhenyu Liang
The CQ bit was checked by zhenyu.liang@intel.com
6 years, 9 months ago (2014-03-13 03:01:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhenyu.liang@intel.com/185423006/80001
6 years, 9 months ago (2014-03-13 03:02:16 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 03:32:50 UTC) #19
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=55082
6 years, 9 months ago (2014-03-13 03:32:51 UTC) #20
Zhenyu Liang
The CQ bit was unchecked by zhenyu.liang@intel.com
6 years, 9 months ago (2014-03-17 02:47:17 UTC) #21
Zhenyu Liang
The CQ bit was checked by zhenyu.liang@intel.com
6 years, 9 months ago (2014-03-17 02:47:24 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhenyu.liang@intel.com/185423006/80001
6 years, 9 months ago (2014-03-17 02:47:29 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 03:10:28 UTC) #24
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=55595
6 years, 9 months ago (2014-03-17 03:10:29 UTC) #25
Zhenyu Liang
The CQ bit was checked by zhenyu.liang@intel.com
6 years, 9 months ago (2014-03-19 02:47:02 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhenyu.liang@intel.com/185423006/80001
6 years, 9 months ago (2014-03-19 02:48:05 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 02:48:13 UTC) #28
commit-bot: I haz the power
Failed to apply patch for base/debug/proc_maps_linux.cc: While running patch -p0 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-19 02:48:14 UTC) #29
Zhenyu Liang
The CQ bit was checked by zhenyu.liang@intel.com
6 years, 9 months ago (2014-03-19 03:05:07 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhenyu.liang@intel.com/185423006/100001
6 years, 9 months ago (2014-03-19 03:06:35 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 03:38:08 UTC) #32
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=284186
6 years, 9 months ago (2014-03-19 03:38:09 UTC) #33
Zhenyu Liang
The CQ bit was checked by zhenyu.liang@intel.com
6 years, 9 months ago (2014-03-19 07:13:23 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhenyu.liang@intel.com/185423006/100001
6 years, 9 months ago (2014-03-19 07:13:41 UTC) #35
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 12:00:51 UTC) #36
Message was sent while issue was closed.
Change committed as 257942

Powered by Google App Engine
This is Rietveld 408576698