Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1854213002: Add support for serializing 'target[index]' expressions. (Closed)

Created:
4 years, 8 months ago by scheglov
Modified:
4 years, 8 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for serializing 'target[index]' expressions. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1b83b01011285a7fdbd3e7f54d1b8284a542470b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M pkg/analyzer/lib/src/summary/format.fbs View Binary file 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_const_expr.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 8 months ago (2016-04-04 18:40:11 UTC) #1
Paul Berry
lgtm
4 years, 8 months ago (2016-04-04 18:55:00 UTC) #2
scheglov
4 years, 8 months ago (2016-04-04 19:03:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b83b01011285a7fdbd3e7f54d1b8284a542470b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698