Switch internal testing ImageFilters over to new onFilterImage interface

Switch internal testing ImageFilters over to new onFilterImage interface
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1854133002

Committed: https://skia.googlesource.com/skia/+/4ba94e26106a4ecab4d3841d702b57487b82334e

[robertphillips, 2016-04-04 15:36:51]

Description was changed from

==========
Switch internal testing ImageFilters over to new onFilterImage interface
==========

to

==========
Switch internal testing ImageFilters over to new onFilterImage interface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-04 15:41:05]

Description was changed from

==========
Switch internal testing ImageFilters over to new onFilterImage interface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Switch internal testing ImageFilters over to new onFilterImage interface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-04 15:41:05]

robertphillips@google.com changed reviewers:
+ senorblanco@chromium.org, senorblanco@google.com

[Stephen White, 2016-04-04 17:02:43]

https://codereview.chromium.org/1854133002/diff/20001/gm/imagefiltersbase.cpp
File gm/imagefiltersbase.cpp (right):

https://codereview.chromium.org/1854133002/diff/20001/gm/imagefiltersbase.cpp...
gm/imagefiltersbase.cpp:84: return sk_ref_sp<SkSpecialImage>(source);
Let's not do this until we get the null_ptr-as-transparent-black issue sorted
out.

https://codereview.chromium.org/1854133002/diff/20001/gm/imagefiltersgraph.cpp
File gm/imagefiltersgraph.cpp (right):

https://codereview.chromium.org/1854133002/diff/20001/gm/imagefiltersgraph.cp...
gm/imagefiltersgraph.cpp:27: // More closely models how Blink's OffsetFilter
works as of 10/23/13. SkOffsetImageFilter doesn't
Blink's OffsetFilter doesn't exist anymore. We should probably replace this with
SkOffsetImageFilter.

[robertphillips, 2016-04-04 18:08:31]

https://codereview.chromium.org/1854133002/diff/20001/gm/imagefiltersbase.cpp
File gm/imagefiltersbase.cpp (right):

https://codereview.chromium.org/1854133002/diff/20001/gm/imagefiltersbase.cpp...
gm/imagefiltersbase.cpp:84: return sk_ref_sp<SkSpecialImage>(source);
On 2016/04/04 17:02:42, Stephen White wrote:
> Let's not do this until we get the null_ptr-as-transparent-black issue sorted
> out.

I seems like this is actually what this test image filter wants to do though
(i.e., just return the unmodified input).

[Stephen White, 2016-04-04 18:43:16]

LGTM

https://codereview.chromium.org/1854133002/diff/20001/gm/imagefiltersbase.cpp
File gm/imagefiltersbase.cpp (right):

https://codereview.chromium.org/1854133002/diff/20001/gm/imagefiltersbase.cpp...
gm/imagefiltersbase.cpp:84: return sk_ref_sp<SkSpecialImage>(source);
On 2016/04/04 18:08:31, robertphillips wrote:
> On 2016/04/04 17:02:42, Stephen White wrote:
> > Let's not do this until we get the null_ptr-as-transparent-black issue
sorted
> > out.
> 
> I seems like this is actually what this test image filter wants to do though
> (i.e., just return the unmodified input).

Oh! Yeah, I guess it does. It's returning the source primitive, though, not its
input. Probably predates the DAG. Anyway this is fine.

[robertphillips, 2016-04-04 18:54:53]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 18:54:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854133002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854133002/20001

[commit-bot: I haz the power, 2016-04-04 19:06:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 19:06:27]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-04-04 19:06:45]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-04-04 19:06:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854133002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854133002/20001

[commit-bot: I haz the power, 2016-04-04 19:07:49]

Description was changed from

==========
Switch internal testing ImageFilters over to new onFilterImage interface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Switch internal testing ImageFilters over to new onFilterImage interface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/4ba94e26106a4ecab4d3841d702b57487b82334e
==========

[commit-bot: I haz the power, 2016-04-04 19:07:50]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4ba94e26106a4ecab4d3841d702b57487b82334e