Source/bindings/scripts/v8_callback_interface.py - Issue 185413023: Oilpan: move Touch related objects to the oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_callback_interface.py

Issue 185413023: Oilpan: move Touch related objects to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added 2 binding tests + style Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_callback_interface.py

diff --git a/Source/bindings/scripts/v8_callback_interface.py b/Source/bindings/scripts/v8_callback_interface.py

index 64fa4b7b8c674b2f2134c2e54f06d135a9aeaaaf..26c62957a44c8a40edefab9f6b8bb1d585a2cbd6 100644

--- a/Source/bindings/scripts/v8_callback_interface.py

+++ b/Source/bindings/scripts/v8_callback_interface.py

@@ -73,7 +73,7 @@ def cpp_type(idl_type):

return 'void'

# Callbacks use raw pointers, so used_as_argument=True

usual_cpp_type = v8_types.cpp_type(idl_type, used_as_argument=True)

- if usual_cpp_type.startswith('Vector'):

+ if usual_cpp_type.startswith(('Vector', 'WillBeHeapVector')):

return 'const %s&' % usual_cpp_type

return usual_cpp_type

« no previous file with comments | « no previous file | Source/bindings/scripts/v8_methods.py » ('j') | Source/bindings/scripts/v8_types.py » ('J')