Source/bindings/templates/methods.cpp - Issue 185413023: Oilpan: move Touch related objects to the oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/methods.cpp

Issue 185413023: Oilpan: move Touch related objects to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Improve element type of variadic vectors Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/templates/methods.cpp

diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp

index f9c7d8272f91dc10fa0415a5187d0182075b82ee..af7ecd38b3d5695a7d48a44446b7accdc22b2379 100644

--- a/Source/bindings/templates/methods.cpp

+++ b/Source/bindings/templates/methods.cpp

@@ -148,7 +148,7 @@ if (!std::isnan({{argument.name}}NativeValue))

if (exceptionState.throwIfNeeded())

return;

{% elif argument.is_variadic_wrapper_type %}

-Vector<{{argument.cpp_type}} > {{argument.name}};

+{{argument.vector_type}}<{{argument.cpp_type}} > {{argument.name}};

for (int i = {{argument.index}}; i < info.Length(); ++i) {

if (!V8{{argument.idl_type}}::hasInstance(info[i], info.GetIsolate())) {

{{throw_type_error(method, '"parameter %s is not of type \'%s\'."' %

« Source/bindings/scripts/v8_types.py ('K') | « Source/bindings/scripts/v8_types.py ('k') | Source/bindings/tests/idls/TestObjectPython.idl » ('j') | Source/core/dom/Touch.idl » ('J')