Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: Source/bindings/scripts/v8_callback_interface.py

Issue 185413023: Oilpan: move Touch related objects to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Improve element type of variadic vectors Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_methods.py » ('j') | Source/bindings/scripts/v8_methods.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_callback_interface.py
diff --git a/Source/bindings/scripts/v8_callback_interface.py b/Source/bindings/scripts/v8_callback_interface.py
index 64fa4b7b8c674b2f2134c2e54f06d135a9aeaaaf..26c62957a44c8a40edefab9f6b8bb1d585a2cbd6 100644
--- a/Source/bindings/scripts/v8_callback_interface.py
+++ b/Source/bindings/scripts/v8_callback_interface.py
@@ -73,7 +73,7 @@ def cpp_type(idl_type):
return 'void'
# Callbacks use raw pointers, so used_as_argument=True
usual_cpp_type = v8_types.cpp_type(idl_type, used_as_argument=True)
- if usual_cpp_type.startswith('Vector'):
+ if usual_cpp_type.startswith(('Vector', 'WillBeHeapVector')):
Nils Barth (inactive) 2014/03/05 07:49:13 Could you add a test case to TestCallbackInterface
sof 2014/03/05 08:15:17 Done; I actually think 'HeapVector' should also be
Nils Barth (inactive) 2014/03/05 09:20:10 We can cross that bridge when we come to it, I ass
return 'const %s&' % usual_cpp_type
return usual_cpp_type
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_methods.py » ('j') | Source/bindings/scripts/v8_methods.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698