Oilpan: move Touch related objects to the oilpan heap.

Source/bindings/scripts/v8_methods.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 122 matching lines @@
         'v8_set_return_value_for_main_world': v8_set_return_value(interface.name, method, this_cpp_value, for_main_world=True),
         'v8_set_return_value': v8_set_return_value(interface.name, method, this_cpp_value),
         'world_suffixes': ['', 'ForMainWorld'] if 'PerWorldBindings' in extended_attributes else [''],  # [PerWorldBindings]
     }
 
 
 def generate_argument(interface, method, argument, index):
     extended_attributes = argument.extended_attributes
     idl_type = argument.idl_type
     this_cpp_value = cpp_value(interface, method, index)
+    is_variadic_wrapper_type = argument.is_variadic and v8_types.is_wrapper_type(idl_type)
+    use_heap_vector_type = is_variadic_wrapper_type and v8_types.is_will_be_garbage_collected(idl_type)
     return {
-        'cpp_type': v8_types.cpp_type(idl_type),
+        'cpp_type': v8_types.cpp_type(idl_type, used_as_member=use_heap_vector_type),
         'cpp_value': this_cpp_value,
         'enum_validation_expression': v8_utilities.enum_validation_expression(idl_type),
         'has_default': 'Default' in extended_attributes,
         'idl_type': idl_type,
         'index': index,
         'is_clamp': 'Clamp' in extended_attributes,
         'is_callback_interface': v8_types.is_callback_interface(idl_type),
         'is_nullable': argument.is_nullable,
         'is_optional': argument.is_optional,
         'is_strict_type_checking': 'StrictTypeChecking' in extended_attributes,
-        'is_variadic_wrapper_type': argument.is_variadic and v8_types.is_wrapper_type(idl_type),
+        'is_variadic_wrapper_type': is_variadic_wrapper_type,
+        'vector_type': 'WillBeHeapVector' if use_heap_vector_type else 'Vector',

[Nils Barth (inactive), 2014/03/05 07:49:13]

+haraken@: thoughts on naming?
Technically Vector/WillBeHeapVector are templates, not types themselves.
Tersest would simply be 'vector' (as for 'ref_ptr', 'pass_ref_ptr'),
as this is basically VectorExceptWeNeedTransitionTypes,
and this avoids the transition types making the CG ugly.
Most verbose would be 'vector_template'.

Thoughts?

[sof, 2014/03/05 08:15:17]

I think vector_type is fine (possibly with a cpp_ prefix), but
(cpp_)vector_type_name is an alternative.

[Nils Barth (inactive), 2014/03/05 09:20:10]

Barring objections from haraken, this seems fine.

         'is_wrapper_type': v8_types.is_wrapper_type(idl_type),
         'name': argument.name,
         'v8_set_return_value_for_main_world': v8_set_return_value(interface.name, method, this_cpp_value, for_main_world=True),
         'v8_set_return_value': v8_set_return_value(interface.name, method, this_cpp_value),
         'v8_value_to_local_cpp_value': v8_value_to_local_cpp_value(argument, index),
     }
 
 
 ################################################################################
 # Value handling
@@ skipping 49 matching lines @@
 
     script_wrappable = 'imp' if v8_types.inherits_interface(interface_name, 'Node') else ''
     return v8_types.v8_set_return_value(idl_type, cpp_value, extended_attributes, script_wrappable=script_wrappable, release=release, for_main_world=for_main_world)
 
 
 def v8_value_to_local_cpp_value(argument, index):
     extended_attributes = argument.extended_attributes
     idl_type = argument.idl_type
     name = argument.name
     if argument.is_variadic:
-        return 'V8TRYCATCH_VOID(Vector<{cpp_type}>, {name}, toNativeArguments<{cpp_type}>(info, {index}))'.format(
-                cpp_type=v8_types.cpp_type(idl_type), name=name, index=index)
+        vector_type = 'WillBeHeapVector' if v8_types.is_will_be_garbage_collected(idl_type) else 'Vector'
+        return 'V8TRYCATCH_VOID({vector_type}<{cpp_type}>, {name}, toNativeArguments<{cpp_type}>(info, {index}))'.format(
+                cpp_type=v8_types.cpp_type(idl_type), name=name, index=index, vector_type=vector_type)
     # [Default=NullString]
     if (argument.is_optional and idl_type == 'DOMString' and
         extended_attributes.get('Default') == 'NullString'):
         v8_value = 'argumentOrNull(info, %s)' % index
     else:
         v8_value = 'info[%s]' % index
     return v8_types.v8_value_to_local_cpp_value(
         idl_type, argument.extended_attributes, v8_value, name, index=index)
 
 
@@ skipping 14 matching lines @@
     return property_attributes_list
 
 
 def union_arguments(idl_type):
     """Return list of ['result0Enabled', 'result0', 'result1Enabled', ...] for union types, for use in setting return value"""
     if not v8_types.is_union_type(idl_type):
         return None
     return [arg
             for i in range(len(idl_type.union_member_types))
             for arg in ['result%sEnabled' % i, 'result%s' % i]]