content/test/content_test_launcher.cc - Issue 185413019: Used scoped_ptr in InitMessagePumpForUIFactory and CreateMessagePumpForType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/content_test_launcher.cc

Issue 185413019: Used scoped_ptr in InitMessagePumpForUIFactory and CreateMessagePumpForType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes in accordance to build fail for linux chromeos Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/test/content_test_launcher.cc

diff --git a/content/test/content_test_launcher.cc b/content/test/content_test_launcher.cc

index 09078b23dd905dc86b8a201f1d8c7f3aedde491c..e61d3972b4952c5558eb398f0954442eeba825bd 100644

--- a/content/test/content_test_launcher.cc

+++ b/content/test/content_test_launcher.cc

@@ -61,8 +61,8 @@ class ContentShellTestSuiteInitializer

};

#if defined(OS_ANDROID)

-base::MessagePump* CreateMessagePumpForUI() {

- return new NestedMessagePumpAndroid();

+scoped_ptr<base::MessagePump> CreateMessagePumpForUI() {

+ return scoped_ptr<base::MessagePump>(new NestedMessagePumpAndroid());

};

#endif

« no previous file with comments | « content/shell/browser/shell_layout_tests_android.cc ('k') | mojo/common/message_pump_mojo_unittest.cc » ('j') | no next file with comments »