runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.dart - Issue 185413015: Update the navbar in the observatory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.dart

Issue 185413015: Update the navbar in the observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: new js Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/client/lib/src/observatory_elements/function_view.html ('k') | runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.dart

diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.dart b/runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.dart

index 96ebf2773be9c42892a89911c73a18720044cdfb..e281a0720e365990c91901e664e1a4529722c367 100644

--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.dart

+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.dart

@@ -222,7 +222,7 @@ class HeapProfileElement extends ObservatoryElement {

throw new FallThroughError();

}

- void refreshData(Event e, var detail, Node target) {

+ void refresh(var done) {

var isolateId = app.locationManager.currentIsolateId();

var isolate = app.isolateManager.getIsolate(isolateId);

if (isolate == null) {

@@ -235,7 +235,7 @@ class HeapProfileElement extends ObservatoryElement {

profile = response;

}).catchError((e, st) {

Logger.root.info('$e $st');

- });

+ }).whenComplete(done);

}

void resetAccumulator(Event e, var detail, Node target) {