runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_list.dart - Issue 185413015: Update the navbar in the observatory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_list.dart

Issue 185413015: Update the navbar in the observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: rebase to master Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.html ('K') | « runtime/bin/vmservice/client/lib/src/observatory_elements/instance_view.html ('k') | runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_list.html » ('j') | runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_list.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_list.dart

diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_list.dart b/runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_list.dart

index c03eca8c2b4e2d1d33b1673268810ab26ba0bfb7..76a17174e98479c5ebc211c874193632c12ddd29 100644

--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_list.dart

+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_list.dart

@@ -4,6 +4,7 @@

library isolate_list_element;

+import 'dart:async';

import 'dart:html';

import 'package:polymer/polymer.dart';

import 'observatory_element.dart';

@@ -13,9 +14,11 @@ import 'observatory_element.dart';

class IsolateListElement extends ObservatoryElement {

IsolateListElement.created() : super.created();

- void refresh(Event e, var detail, Node target) {

+ void refresh(var done) {

+ var futures = [];

app.isolateManager.isolates.forEach((id, isolate) {

- isolate.refresh();

+ futures.add(isolate.refresh());

});

+ Future.wait(futures).then((_) => done());

}