[Telemetry] Move page quiescence test to WebContents

[Telemetry] Move page quiescence test to WebContents

Move quiescence test used by speed index so we can more easily reuse it in other parts of the code.

BUG=339180
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255851

[jeremy, 2014-03-02 13:49:03]

Split off from https://codereview.chromium.org/178363005/

[tonyg, 2014-03-03 04:42:25]

lgtm

https://codereview.chromium.org/185413005/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/web_contents.py (right):

https://codereview.chromium.org/185413005/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/web_contents.py:72: if
(self._has_reached_quiescence):
nit:drop parens.

Thanks for the explanation of the permanence behavior now. That makes total
sense. Maybe add a comment because it isn't obvious?

[jeremy, 2014-03-05 08:57:40]

This needs another round of review (sorry), when I tested this more I ran into a
problem that the page cyclers reuse the same tab for subsequent page loads. 
That means that the webcontents object remains the same but is navigated.

The problem then becomes that a webconents doesn't know about navigation, so it
doesn't know when it needs to re-load the js file containing the resource
tracking code.

I solved that in this iteration of the CL by adding the concept of resetting the
quiescence state of a tab (since the WebContent's quiescence state is sticky).
and making the js file inclusion idempotent so we just run it every time we want
to call the timing function.

[tonyg, 2014-03-05 15:47:54]

https://codereview.chromium.org/185413005/diff/60001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/web_contents.py (right):

https://codereview.chromium.org/185413005/diff/60001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/web_contents.py:56: def
ResetQuiescenceMonitoring(self):
I think for now it would be preferable if the JS took care of the quiescence
persistence. Then callers don't have to work so hard to use this API properly.

[jeremy, 2014-03-06 12:38:21]

Ready for another look: quiescence detection moved to JS.

[tonyg, 2014-03-06 14:46:38]

lgtm

[jeremy, 2014-03-09 13:06:25]

The CQ bit was checked by jeremy@chromium.org

[commit-bot: I haz the power, 2014-03-09 13:06:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremy@chromium.org/185413005/100001

[commit-bot: I haz the power, 2014-03-09 15:06:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-09 15:07:00]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[tonyg, 2014-03-09 15:41:27]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-03-09 15:42:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremy@chromium.org/185413005/100001

[commit-bot: I haz the power, 2014-03-09 16:15:37]

Change committed as 255851