third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h - Issue 1854123002: Rebuild layout attributes on layout instead of on layout tree updates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h

Issue 1854123002: Rebuild layout attributes on layout instead of on layout tree updates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp ('K') | « third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp ('k') | third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h

index 1f66b7535b0358da0d1ce9dbef753d0e8812d45b..81a5763173e78fbca9048e431d73178640c9b6c6 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h

+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h

@@ -47,9 +47,8 @@ class SVGTextLayoutAttributesBuilder {

public:

SVGTextLayoutAttributesBuilder();

bool buildLayoutAttributesForForSubtree(LayoutSVGText&);

- void buildLayoutAttributesForText(LayoutSVGInlineText*);

- void rebuildMetricsForTextLayoutObject(LayoutSVGInlineText*);

+ void rebuildMetricsForTextLayoutObject(LayoutSVGText&, LayoutSVGInlineText&);

// Invoked whenever the underlying DOM tree changes, so that m_textPositions is rebuild.

void clearTextPositioningElements() { m_textPositions.clear(); }