Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp

Issue 1854123002: Rebuild layout attributes on layout instead of on layout tree updates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp
index f510bdbce54663c10d58f88175f08cfcddf1db72..91925f5a1730bcf64db77e00301dbc0670eedeeb 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp
@@ -138,15 +138,9 @@ void LayoutSVGInline::removeChild(LayoutObject* child)
{
SVGResourcesCache::clientWillBeRemovedFromTree(child);
- LayoutSVGText* textLayoutObject = LayoutSVGText::locateLayoutSVGTextAncestor(this);
- if (!textLayoutObject) {
- LayoutInline::removeChild(child);
- return;
- }
- Vector<SVGTextLayoutAttributes*, 2> affectedAttributes;
- textLayoutObject->subtreeChildWillBeRemoved(child, affectedAttributes);
+ if (LayoutSVGText* textLayoutObject = LayoutSVGText::locateLayoutSVGTextAncestor(this))
+ textLayoutObject->subtreeChildWillBeRemoved(child);
LayoutInline::removeChild(child);
- textLayoutObject->subtreeChildWasRemoved(affectedAttributes);
}
void LayoutSVGInline::invalidateTreeIfNeeded(const PaintInvalidationState& paintInvalidationState)

Powered by Google App Engine
This is Rietveld 408576698