Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: src/interpreter/source-position-table.h

Issue 1854113002: [interpreter] statement position always overwrites earlier positions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/interpreter/source-position-table.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/source-position-table.h
diff --git a/src/interpreter/source-position-table.h b/src/interpreter/source-position-table.h
index 0eb885241bcc2ca5d79a84edd8fa54986e1a7b4c..3ac58d621787939383f8d442f241138e06df05a5 100644
--- a/src/interpreter/source-position-table.h
+++ b/src/interpreter/source-position-table.h
@@ -36,12 +36,7 @@ struct PositionTableEntry {
class SourcePositionTableBuilder : public PositionsRecorder {
public:
- enum OnDuplicateCodeOffset {
- DISCARD_DUPLICATE,
- OVERWRITE_DUPLICATE,
- };
-
- explicit SourcePositionTableBuilder(Isolate* isolate, Zone* zone)
+ SourcePositionTableBuilder(Isolate* isolate, Zone* zone)
: isolate_(isolate),
bytes_(zone),
#ifdef ENABLE_SLOW_DCHECKS
@@ -50,17 +45,14 @@ class SourcePositionTableBuilder : public PositionsRecorder {
candidate_(kUninitializedCandidateOffset, 0, false) {
}
- void AddStatementPosition(
- size_t bytecode_offset, int source_position,
- OnDuplicateCodeOffset on_duplicate = DISCARD_DUPLICATE);
+ void AddStatementPosition(size_t bytecode_offset, int source_position);
void AddExpressionPosition(size_t bytecode_offset, int source_position);
Handle<ByteArray> ToSourcePositionTable();
private:
static const int kUninitializedCandidateOffset = -1;
- void AddEntry(const PositionTableEntry& entry,
- OnDuplicateCodeOffset on_duplicate = DISCARD_DUPLICATE);
+ void AddEntry(const PositionTableEntry& entry);
void CommitEntry();
Isolate* isolate_;
« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/interpreter/source-position-table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698