[interpreter] statement position always overwrites earlier positions.

src/interpreter/source-position-table.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/source-position-table.h"
 
 #include "src/objects-inl.h"
 #include "src/objects.h"
 
 namespace v8 {
@@ skipping 97 matching lines @@
 
   // Note that '>>' needs to be arithmetic shift in order to handle negative
   // numbers properly.
   entry->bytecode_offset = (tmp >> 1);
 
   DecodeInt(bytes, index, &entry->source_position);
 }
 
 }  // namespace
 
-void SourcePositionTableBuilder::AddStatementPosition(
-    size_t bytecode_offset, int source_position,
-    SourcePositionTableBuilder::OnDuplicateCodeOffset on_duplicate) {
+void SourcePositionTableBuilder::AddStatementPosition(size_t bytecode_offset,
+                                                      int source_position) {
   int offset = static_cast<int>(bytecode_offset);
-  AddEntry({offset, source_position, true}, on_duplicate);
-  LOG_CODE_EVENT(isolate_, CodeLinePosInfoAddStatementPositionEvent(
-                               jit_handler_data_, offset, source_position));
-  LOG_CODE_EVENT(isolate_, CodeLinePosInfoAddPositionEvent(
-                               jit_handler_data_, offset, source_position));
+  AddEntry({offset, source_position, true});
 }
 
 void SourcePositionTableBuilder::AddExpressionPosition(size_t bytecode_offset,
                                                        int source_position) {
   int offset = static_cast<int>(bytecode_offset);
   AddEntry({offset, source_position, false});
   LOG_CODE_EVENT(isolate_, CodeLinePosInfoAddPositionEvent(

[Michael Starzinger, 2016/04/04 17:16:45]

Isn't this event now covered by the events fired in CommitEntry as well?

[Yang, 2016/04/05 08:50:03]

Correct. I forgot to remove this one.

                                jit_handler_data_, offset, source_position));
 }
 
-void SourcePositionTableBuilder::AddEntry(
-    const PositionTableEntry& entry,
-    SourcePositionTableBuilder::OnDuplicateCodeOffset on_duplicate) {
+void SourcePositionTableBuilder::AddEntry(const PositionTableEntry& entry) {
   // Don't encode a new entry if this bytecode already has a source position
   // assigned.
   if (candidate_.bytecode_offset == entry.bytecode_offset) {
-    if ((!candidate_.is_statement && entry.is_statement) ||
-        on_duplicate == OVERWRITE_DUPLICATE) {
-      candidate_ = entry;
-    }
+    if (entry.is_statement) candidate_ = entry;
     return;
   }
 
   CommitEntry();
   candidate_ = entry;
 }
 
 void SourcePositionTableBuilder::CommitEntry() {
   if (candidate_.bytecode_offset == kUninitializedCandidateOffset) return;
   PositionTableEntry tmp(candidate_);
   SubtractFromEntry(tmp, previous_);
   EncodeEntry(bytes_, tmp);
   previous_ = candidate_;
 
+  if (candidate_.is_statement) {
+    LOG_CODE_EVENT(isolate_, CodeLinePosInfoAddStatementPositionEvent(
+                                 jit_handler_data_, candidate_.bytecode_offset,
+                                 candidate_.source_position));
+  }
+  LOG_CODE_EVENT(isolate_, CodeLinePosInfoAddPositionEvent(
+                               jit_handler_data_, candidate_.bytecode_offset,
+                               candidate_.source_position));
+
 #ifdef ENABLE_SLOW_DCHECKS
   raw_entries_.push_back(candidate_);
 #endif
 }
 
 Handle<ByteArray> SourcePositionTableBuilder::ToSourcePositionTable() {
   CommitEntry();
   if (bytes_.empty()) return isolate_->factory()->empty_byte_array();
 
   Handle<ByteArray> table = isolate_->factory()->NewByteArray(
@@ skipping 31 matching lines @@
   } else {
     PositionTableEntry tmp;
     DecodeEntry(table_, &index_, &tmp);
     AddAndSetEntry(current_, tmp);
   }
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8