Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1854033002: Revert of Replace all occurrences of RELEASE_ASSERT in wtf with CHECK. (Closed)

Created:
4 years, 8 months ago by tkent
Modified:
4 years, 8 months ago
CC:
Mads Ager (chromium), blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, kouhei+heap_chromium.org, Mikhail, oilpan-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Replace all occurrences of RELEASE_ASSERT in wtf with CHECK. (patchset #4 id:60001 of https://codereview.chromium.org/1840163002/ ) Reason for revert: Caused performance regression; crbug.com/599867 Original issue's description: > Replace all occurrences of RELEASE_ASSERT in wtf with CHECK. > > BUG=596760 > > Committed: https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c > Cr-Commit-Position: refs/heads/master@{#384213} TBR=haraken@chromium.org,yutak@chromium.org,kotenkov@yandex-team.ru BUG=596760, 599867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -89 lines) Patch
M third_party/WebKit/Source/wtf/ArrayBuffer.h View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/wtf/BitArray.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/Deque.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/Functional.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/HashTable.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/Optional.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/PageAllocator.cpp View 7 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/wtf/PartitionAlloc.h View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/wtf/PartitionAlloc.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/PartitionAllocator.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Partitions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/TerminatedArrayBuilder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/TypedArrayBase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Vector.h View 7 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/wtf/WTF.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/dtoa/utils.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/AtomicString.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/CString.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/StringConcatenate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringConcatenate.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.cpp View 14 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecUTF16.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.cpp View 9 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
Created Revert of Replace all occurrences of RELEASE_ASSERT in wtf with CHECK.
4 years, 8 months ago (2016-04-03 17:55:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854033002/1
4 years, 8 months ago (2016-04-03 17:55:57 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/13039) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-03 17:58:09 UTC) #6
kotenkov
There are conflicts already, I've seen them while investigating the issue, you'll have to rebase. ...
4 years, 8 months ago (2016-04-03 17:59:59 UTC) #7
haraken
4 years, 8 months ago (2016-04-03 23:33:54 UTC) #8
Message was sent while issue was closed.
On 2016/04/03 17:59:59, kotenkov wrote:
> There are conflicts already, I've seen them while investigating the issue,
> you'll have to rebase.
> It seems that the bottleneck is the Vector.h, at least for blink_perf.events.
> I'll write further in the bug.

Yeah, this regression needs to be addressed.

Powered by Google App Engine
This is Rietveld 408576698