Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 185403019: Revert of IndexedDB: Don't timeout read-only transactions (Closed)

Created:
6 years, 9 months ago by stgao
Modified:
6 years, 9 months ago
Reviewers:
dgrogan, jsbell, cmumford
CC:
chromium-reviews, jam, alecflett, ericu+idb_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, cmumford, dgrogan, jsbell+idb_chromium.org
Visibility:
Public.

Description

Revert of IndexedDB: Don't timeout read-only transactions (https://codereview.chromium.org/180163010/) Reason for revert: Break Chromium Memory on Linux ASan+LSan Tests (2) http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%282%29/builds/65/steps/content_unittests/logs/NoTimeoutReadOnly Original issue's description: > IndexedDB: Don't timeout read-only transactions > > Chrome introduced a transaction timeout to deal with potentially wedged > renderers (e.g. JS execution halted, etc) failing to complete transactions, > leaving the browser's transaction queue in a bad state. This was done > for all transactions, but since read-only transactions don't hold up > the queue it's safe to ignore them, which can reduce false-positives. > > BUG=339229 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254846 TBR=dgrogan@chromium.org,cmumford@chromium.org,jsbell@chromium.org NOTREECHECKS=true NOTRY=true BUG=339229 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254868

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -36 lines) Patch
M content/browser/indexed_db/indexed_db_transaction.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M content/browser/indexed_db/indexed_db_transaction_unittest.cc View 2 chunks +1 line, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
stgao
Created Revert of IndexedDB: Don't timeout read-only transactions
6 years, 9 months ago (2014-03-04 22:59:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stgao@chromium.org/185403019/1
6 years, 9 months ago (2014-03-04 23:00:36 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 23:02:37 UTC) #3
Message was sent while issue was closed.
Change committed as 254868

Powered by Google App Engine
This is Rietveld 408576698