Index: tests/ImageFilterTest.cpp |
diff --git a/tests/ImageFilterTest.cpp b/tests/ImageFilterTest.cpp |
index 3f60286e39d6da3b3369bbc22f21c65fa407030b..4da706b278fad11fd53e3bca2c1cecc128f47556 100644 |
--- a/tests/ImageFilterTest.cpp |
+++ b/tests/ImageFilterTest.cpp |
@@ -51,20 +51,21 @@ namespace { |
class MatrixTestImageFilter : public SkImageFilter { |
public: |
- MatrixTestImageFilter(skiatest::Reporter* reporter, const SkMatrix& expectedMatrix) |
- : SkImageFilter(0, nullptr), fReporter(reporter), fExpectedMatrix(expectedMatrix) { |
+ static sk_sp<SkImageFilter> Make(skiatest::Reporter* reporter, |
+ const SkMatrix& expectedMatrix) { |
+ return sk_sp<SkImageFilter>(new MatrixTestImageFilter(reporter, expectedMatrix)); |
} |
+ SK_TO_STRING_OVERRIDE() |
+ SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(MatrixTestImageFilter) |
+ |
+protected: |
bool onFilterImageDeprecated(Proxy*, const SkBitmap& src, const Context& ctx, |
SkBitmap* result, SkIPoint* offset) const override { |
REPORTER_ASSERT(fReporter, ctx.ctm() == fExpectedMatrix); |
return true; |
} |
- SK_TO_STRING_OVERRIDE() |
- SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(MatrixTestImageFilter) |
- |
-protected: |
void flatten(SkWriteBuffer& buffer) const override { |
this->INHERITED::flatten(buffer); |
buffer.writeFunctionPtr(fReporter); |
@@ -72,6 +73,12 @@ protected: |
} |
private: |
+ MatrixTestImageFilter(skiatest::Reporter* reporter, const SkMatrix& expectedMatrix) |
+ : INHERITED(nullptr, 0, nullptr) |
+ , fReporter(reporter) |
+ , fExpectedMatrix(expectedMatrix) { |
+ } |
+ |
skiatest::Reporter* fReporter; |
SkMatrix fExpectedMatrix; |
@@ -224,7 +231,7 @@ sk_sp<SkFlattenable> MatrixTestImageFilter::CreateProc(SkReadBuffer& buffer) { |
skiatest::Reporter* reporter = (skiatest::Reporter*)buffer.readFunctionPtr(); |
SkMatrix matrix; |
buffer.readMatrix(&matrix); |
- return sk_make_sp<MatrixTestImageFilter>(reporter, matrix); |
+ return MatrixTestImageFilter::Make(reporter, matrix); |
} |
#ifndef SK_IGNORE_TO_STRING |
@@ -1002,9 +1009,7 @@ DEF_TEST(ImageFilterMatrix, reporter) { |
SkCanvas* recordingCanvas = recorder.beginRecording(100, 100, &factory, 0); |
SkPaint paint; |
- SkAutoTUnref<MatrixTestImageFilter> imageFilter( |
- new MatrixTestImageFilter(reporter, expectedMatrix)); |
- paint.setImageFilter(imageFilter.get()); |
+ paint.setImageFilter(MatrixTestImageFilter::Make(reporter, expectedMatrix)); |
recordingCanvas->saveLayer(nullptr, &paint); |
SkPaint solidPaint; |
solidPaint.setColor(0xFFFFFFFF); |