Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1854023003: Update internal testing ImageFilters to sk_sp (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -45 lines) Patch
M gm/imagefiltersbase.cpp View 1 6 chunks +13 lines, -10 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 1 6 chunks +22 lines, -18 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 4 chunks +15 lines, -10 lines 0 comments Download
M tests/PDFPrimitivesTest.cpp View 3 chunks +15 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
robertphillips
4 years, 8 months ago (2016-04-03 19:51:46 UTC) #4
reed1
lgtm https://codereview.chromium.org/1854023003/diff/1/gm/imagefiltersbase.cpp File gm/imagefiltersbase.cpp (right): https://codereview.chromium.org/1854023003/diff/1/gm/imagefiltersbase.cpp#newcode199 gm/imagefiltersbase.cpp:199: SkImageFilter* filters[] = { at some point we ...
4 years, 8 months ago (2016-04-03 21:29:24 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854023003/20001
4 years, 8 months ago (2016-04-04 11:39:22 UTC) #7
robertphillips
https://codereview.chromium.org/1854023003/diff/1/gm/imagefiltersbase.cpp File gm/imagefiltersbase.cpp (right): https://codereview.chromium.org/1854023003/diff/1/gm/imagefiltersbase.cpp#newcode199 gm/imagefiltersbase.cpp:199: SkImageFilter* filters[] = { On 2016/04/03 21:29:24, reed1 wrote: ...
4 years, 8 months ago (2016-04-04 11:46:22 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-04 11:58:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854023003/20001
4 years, 8 months ago (2016-04-04 12:04:19 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 12:05:15 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/43c2ad4e8f9ed84f46caa57e0b471f7393f1280a

Powered by Google App Engine
This is Rietveld 408576698