Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1853973002: S390: Use FIEBRA/FIDBRA for FP Floor/Ceil (Closed)

Created:
4 years, 8 months ago by JoranSiu
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Use FIEBRA/FIDBRA for FP Floor/Ceil The existing FloatFloor/Ceiling functions had an issue with handling Number.MIN_VALUE (0x1 ==> 5e-324), and would incorrectly return MIN_VALUE instead of 0/1. Simplify the entire sequence by using the available hardware instruction with the appropriate rounding mode (POS_INF for Ceiling, NEG_INF for Floor). Add missing FIEBRA/FIDBRA cases to disassembler. R=jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com BUG= Committed: https://crrev.com/06d7276b24384b134915b6b55a24ce9d1e022d02 Cr-Commit-Position: refs/heads/master@{#35239}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -181 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M src/s390/disasm-s390.cc View 2 chunks +12 lines, -2 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +0 lines, -16 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 chunk +0 lines, -154 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853973002/1
4 years, 8 months ago (2016-04-03 04:33:04 UTC) #2
JoranSiu
PTAL
4 years, 8 months ago (2016-04-03 04:34:03 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-03 04:51:55 UTC) #5
john.yan
lgtm
4 years, 8 months ago (2016-04-04 13:17:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853973002/1
4 years, 8 months ago (2016-04-04 13:31:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 13:53:30 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 13:54:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06d7276b24384b134915b6b55a24ce9d1e022d02
Cr-Commit-Position: refs/heads/master@{#35239}

Powered by Google App Engine
This is Rietveld 408576698