[Courgette] Refactor LabelManager.

[Courgette] Refactor LabelManager.

Some code cleanup before the big CL to use LabelManager to reduce peak
memory by 25%:
- Remove LabelManagerImpl and simply use LabelManager.
- Extract RvaVisitor to a separate class; adding specializations:
  - VectorRvaVisitor<T>: To prepare for for RVA and TypedRVA usage.
  - TrivialRvaVisitor: For unittests.

Committed: https://crrev.com/9faa303317b028dc4e78ccf22457a985530efffe
Cr-Commit-Position: refs/heads/master@{#385645}

[huangs, 2016-04-04 14:30:57]

huangs@chromium.org changed reviewers:
+ wfh@chromium.org

[huangs, 2016-04-04 14:30:58]

PTAL.  Thanks!

https://codereview.chromium.org/1853943002/diff/1/courgette/image_utils.h
File courgette/image_utils.h (right):

https://codereview.chromium.org/1853943002/diff/1/courgette/image_utils.h#new...
courgette/image_utils.h:133: // RvaVisitor that simply stores a list of RVAs for
traversal. For testing.
We'll reuse it in adjustment_method_unittest.cc -- otherwise this could have
just been in label_manager_unittests.cc.

[huangs, 2016-04-06 17:28:55]

Ping for review, PTAL.  Thanks!

[Will Harris, 2016-04-06 17:55:54]

https://codereview.chromium.org/1853943002/diff/1/courgette/label_manager.h
File courgette/label_manager.h (left):

https://codereview.chromium.org/1853943002/diff/1/courgette/label_manager.h#o...
courgette/label_manager.h:139: size_t Size() const override;
where did Size() go and why isn't it needed?

[huangs, 2016-04-06 18:28:05]

https://codereview.chromium.org/1853943002/diff/1/courgette/label_manager.h
File courgette/label_manager.h (left):

https://codereview.chromium.org/1853943002/diff/1/courgette/label_manager.h#o...
courgette/label_manager.h:139: size_t Size() const override;
LabelManager::Labels() is moved from private: to public:, so caller can just
call label_manager.Labels().size().

[Will Harris, 2016-04-06 21:49:44]

okay lgtm if the bots like it :

[huangs, 2016-04-06 21:59:18]

Cool.  Thanks!

[huangs, 2016-04-06 21:59:25]

The CQ bit was checked by huangs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 22:00:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1853943002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1853943002/1

[commit-bot: I haz the power, 2016-04-07 02:03:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 02:03:20]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[huangs, 2016-04-07 02:04:20]

The CQ bit was checked by huangs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 02:04:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1853943002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1853943002/1

[commit-bot: I haz the power, 2016-04-07 03:30:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 03:30:40]

Dry run: This issue passed the CQ dry run.

[huangs, 2016-04-07 03:31:06]

The CQ bit was checked by huangs@chromium.org

[commit-bot: I haz the power, 2016-04-07 03:31:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1853943002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1853943002/1

[commit-bot: I haz the power, 2016-04-07 03:37:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-07 03:38:41]

Description was changed from

==========
[Courgette] Refactor LabelManager.

Some code cleanup before the big CL to use LabelManager to reduce peak
memory by 25%:
- Remove LabelManagerImpl and simply use LabelManager.
- Extract RvaVisitor to a separate class; adding specializations:
  - VectorRvaVisitor<T>: To prepare for for RVA and TypedRVA usage.
  - TrivialRvaVisitor: For unittests.
==========

to

==========
[Courgette] Refactor LabelManager.

Some code cleanup before the big CL to use LabelManager to reduce peak
memory by 25%:
- Remove LabelManagerImpl and simply use LabelManager.
- Extract RvaVisitor to a separate class; adding specializations:
  - VectorRvaVisitor<T>: To prepare for for RVA and TypedRVA usage.
  - TrivialRvaVisitor: For unittests.

Committed: https://crrev.com/9faa303317b028dc4e78ccf22457a985530efffe
Cr-Commit-Position: refs/heads/master@{#385645}
==========

[commit-bot: I haz the power, 2016-04-07 03:38:42]

Patchset 1 (id:??) landed as
https://crrev.com/9faa303317b028dc4e78ccf22457a985530efffe
Cr-Commit-Position: refs/heads/master@{#385645}