Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 185393015: Rename shapeSize and others to make ShapeInfo and friends easier to understand (Closed)

Created:
6 years, 9 months ago by Bem Jones-Bey (adobe)
Modified:
6 years, 9 months ago
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr.
Visibility:
Public.

Description

Rename shapeSize and others to make ShapeInfo and friends easier to understand The ShapeInfo hierarchy has grown organically as the spec has changed, and the naming has become very stale and confusing. The spec is now in Last Call, so it seems like a good time to take a stab towards better naming that matches the spec terminology and is also more consistent in general. R=leviw@chromium.org BUG=322165 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168409

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -50 lines) Patch
M Source/core/rendering/RenderBlock.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 5 chunks +5 lines, -5 lines 1 comment Download
M Source/core/rendering/RenderBlockFlow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/shapes/ShapeInfo.h View 4 chunks +19 lines, -23 lines 1 comment Download
M Source/core/rendering/shapes/ShapeInfo.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/shapes/ShapeInsideInfo.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/shapes/ShapeInsideInfo.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/shapes/ShapeOutsideInfo.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/shapes/ShapeOutsideInfo.cpp View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Bem Jones-Bey (adobe)
6 years, 9 months ago (2014-03-03 22:57:07 UTC) #1
leviw_travelin_and_unemployed
LGTM https://codereview.chromium.org/185393015/diff/1/Source/core/rendering/RenderBlock.cpp File Source/core/rendering/RenderBlock.cpp (right): https://codereview.chromium.org/185393015/diff/1/Source/core/rendering/RenderBlock.cpp#newcode1466 Source/core/rendering/RenderBlock.cpp:1466: shapeInsideInfo->setReferenceBoxLogicalSize(LayoutSize(logicalWidth(), percentageLogicalHeightResolvable ? logicalHeight() : LayoutUnit())); So much ...
6 years, 9 months ago (2014-03-03 23:07:20 UTC) #2
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 9 months ago (2014-03-03 23:07:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bjonesbe@adobe.com/185393015/1
6 years, 9 months ago (2014-03-03 23:07:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bjonesbe@adobe.com/185393015/1
6 years, 9 months ago (2014-03-03 23:24:00 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 11:26:16 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=25332
6 years, 9 months ago (2014-03-04 11:26:17 UTC) #7
Bem Jones-Bey (adobe)
The CQ bit was checked by bjonesbe@adobe.com
6 years, 9 months ago (2014-03-04 14:08:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bjonesbe@adobe.com/185393015/1
6 years, 9 months ago (2014-03-04 14:08:47 UTC) #9
Bem Jones-Bey (adobe)
6 years, 9 months ago (2014-03-04 22:32:32 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 manually as r168409 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698