Change media galleries to external file system type to add toURL support

chrome/browser/media_galleries/fileapi/media_file_system_backend.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MEDIA_GALLERIES_FILEAPI_MEDIA_FILE_SYSTEM_BACKEND_H_
 #define CHROME_BROWSER_MEDIA_GALLERIES_FILEAPI_MEDIA_FILE_SYSTEM_BACKEND_H_
 
+#include <string>
+
+#include "base/callback.h"
+#include "base/files/file.h"

[Lei Zhang, 2014/03/20 00:46:26]

base/files/file_path.h

[vandebo (ex-Chrome), 2014/03/20 18:08:53]

Done.

 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
+#include "chrome/browser/media_galleries/media_galleries_preferences.h"
 #include "webkit/browser/fileapi/file_system_backend.h"
 
 namespace base {
 class SequencedTaskRunner;
 }
 
+namespace fileapi {
+class FileSystemURL;
+}
+
 namespace net {
 class URLRequest;
 }
 
 class MediaPathFilter;
-
+class Profile;

[Lei Zhang, 2014/03/20 00:46:26]

not needed?

[vandebo (ex-Chrome), 2014/03/20 18:08:53]

Done.

 class DeviceMediaAsyncFileUtil;
 
 class MediaFileSystemBackend : public fileapi::FileSystemBackend {
  public:
   static const char kMediaTaskRunnerName[];
 
   MediaFileSystemBackend(
       const base::FilePath& profile_path,
       base::SequencedTaskRunner* media_task_runner);
   virtual ~MediaFileSystemBackend();
 
   static bool CurrentlyOnMediaTaskRunnerThread();
   static scoped_refptr<base::SequencedTaskRunner> MediaTaskRunner();
 
+  static std::string ConstructMountName(const base::FilePath& profile_path,

[Lei Zhang, 2014/03/20 00:46:26]

Can you document the behavior w.r.t. |pref_id| ?

[vandebo (ex-Chrome), 2014/03/20 18:08:53]

Not sure what you mean specifically wrt to pref_id... Added a comment.

[Lei Zhang, 2014/03/20 21:37:53]

The special case of pref_id = kInvalidMediaGalleryPrefId

+                                        const std::string& extension_id,
+                                        MediaGalleryPrefId pref_id);
+
   static bool AttemptAutoMountForURLRequest(
       const net::URLRequest* url_request,
       const fileapi::FileSystemURL& filesystem_url,
       const std::string& storage_domain,
       const base::Callback<void(base::File::Error result)>& callback);
 
   // FileSystemBackend implementation.
   virtual bool CanHandleType(fileapi::FileSystemType type) const OVERRIDE;
   virtual void Initialize(fileapi::FileSystemContext* context) OVERRIDE;
   virtual void ResolveURL(const fileapi::FileSystemURL& url,
@@ skipping 39 matching lines @@
   scoped_ptr<fileapi::AsyncFileUtil> itunes_file_util_;
 #endif  // defined(OS_WIN) || defined(OS_MACOSX)
 #if defined(OS_MACOSX)
   scoped_ptr<fileapi::AsyncFileUtil> iphoto_file_util_;
 #endif  // defined(OS_MACOSX)
 
   DISALLOW_COPY_AND_ASSIGN(MediaFileSystemBackend);
 };
 
 #endif  // CHROME_BROWSER_MEDIA_GALLERIES_FILEAPI_MEDIA_FILE_SYSTEM_BACKEND_H_