Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 185393008: gpu: Return early GpuCommandBufferStub::OnWaitSyncPoint() if |sync_point| is 0. (Closed)

Created:
6 years, 9 months ago by dshwang
Modified:
6 years, 9 months ago
Reviewers:
Zhenyao Mo, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

gpu: Return early GpuCommandBufferStub::OnWaitSyncPoint() if |sync_point| is 0. WaitSyncPoint(0) does not do anything, so return early. Accelerated video code path frequently calls WaitSyncPoint(0). BUG=N/A Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255271

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/common/gpu/gpu_command_buffer_stub.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dshwang
6 years, 9 months ago (2014-03-03 11:53:35 UTC) #1
piman
lgtm
6 years, 9 months ago (2014-03-05 22:11:13 UTC) #2
dshwang
On 2014/03/05 22:11:13, piman wrote: > lgtm thank you for lgtm.
6 years, 9 months ago (2014-03-05 22:12:38 UTC) #3
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 9 months ago (2014-03-05 22:12:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/185393008/1
6 years, 9 months ago (2014-03-05 22:14:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/185393008/1
6 years, 9 months ago (2014-03-06 00:05:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/185393008/1
6 years, 9 months ago (2014-03-06 02:48:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/185393008/1
6 years, 9 months ago (2014-03-06 03:13:34 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 05:58:57 UTC) #9
Message was sent while issue was closed.
Change committed as 255271

Powered by Google App Engine
This is Rietveld 408576698