Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1853913002: Clean up and sort chrome/ DEPS entries. (Closed)

Created:
4 years, 8 months ago by Lei Zhang
Modified:
4 years, 8 months ago
Reviewers:
Nicolas Zea, jam
CC:
chromium-reviews, tim+watch_chromium.org, sadrul, zea+watch_chromium.org, feature-media-reviews_chromium.org, tfarina, maxbogue+watch_chromium.org, wfh+watch_chromium.org, plaree+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, grt+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up and sort chrome/ DEPS entries. TBR=jam@chromium.org Committed: https://crrev.com/5e9352a467a72e086e6c14542f215071332d9103 Cr-Commit-Position: refs/heads/master@{#385016}

Patch Set 1 #

Total comments: 2

Patch Set 2 : self review #

Total comments: 2

Patch Set 3 : more sorting #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -64 lines) Patch
M chrome/app/mash/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/DEPS View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/android/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/drive/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/pdf/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/DEPS View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/supervised_user/chromeos/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/sync/DEPS View 1 chunk +1 line, -16 lines 0 comments Download
M chrome/browser/sync/glue/DEPS View 1 chunk +0 lines, -11 lines 0 comments Download
A + chrome/browser/sync/test/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/DEPS View 1 2 2 chunks +10 lines, -11 lines 0 comments Download
M chrome/common/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/DEPS View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/media/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/DEPS View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Lei Zhang
zea: Please review since there's a good amount of sync clean up. Also, sorting is ...
4 years, 8 months ago (2016-04-02 00:55:39 UTC) #3
jam
lgtm
4 years, 8 months ago (2016-04-04 17:23:04 UTC) #4
Nicolas Zea
LGTM with one change https://codereview.chromium.org/1853913002/diff/20001/chrome/browser/ui/webui/DEPS File chrome/browser/ui/webui/DEPS (right): https://codereview.chromium.org/1853913002/diff/20001/chrome/browser/ui/webui/DEPS#newcode8 chrome/browser/ui/webui/DEPS:8: "+sync/internal_api/public/events", swap with above?
4 years, 8 months ago (2016-04-04 20:13:35 UTC) #5
Lei Zhang
https://codereview.chromium.org/1853913002/diff/20001/chrome/browser/ui/webui/DEPS File chrome/browser/ui/webui/DEPS (right): https://codereview.chromium.org/1853913002/diff/20001/chrome/browser/ui/webui/DEPS#newcode8 chrome/browser/ui/webui/DEPS:8: "+sync/internal_api/public/events", On 2016/04/04 20:13:35, Nicolas Zea wrote: > swap ...
4 years, 8 months ago (2016-04-04 21:03:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853913002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853913002/60001
4 years, 8 months ago (2016-04-04 21:05:40 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-04 21:44:15 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 21:45:20 UTC) #13
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/5e9352a467a72e086e6c14542f215071332d9103
Cr-Commit-Position: refs/heads/master@{#385016}

Powered by Google App Engine
This is Rietveld 408576698