Source/bindings/scripts/deprecated_code_generator_v8.pm - Issue 18539006: Have Node inherit EventTarget interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/deprecated_code_generator_v8.pm

Issue 18539006: Have Node inherit EventTarget interface (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/deprecated_code_generator_v8.pm

diff --git a/Source/bindings/scripts/deprecated_code_generator_v8.pm b/Source/bindings/scripts/deprecated_code_generator_v8.pm

index 5ab2224c012ed97f12a06a6106bd36cc9bd9696f..61b92003d0a457ada5e8093293c6537144c47e71 100644

--- a/Source/bindings/scripts/deprecated_code_generator_v8.pm

+++ b/Source/bindings/scripts/deprecated_code_generator_v8.pm

@@ -2191,13 +2191,8 @@ sub GenerateFunction

if (listener) {

V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithNullCheck>, stringResource, args[0]);

impl->${implName}(stringResource, listener${passRefPtrHandling}, args[2]->BooleanValue());

-END

- if (!InheritsInterface($interface, "Node")) {

- $code .= <<END;

- ${hiddenDependencyAction}HiddenDependency(args.Holder(), args[1], ${v8ClassName}::eventListenerCacheIndex, args.GetIsolate());

-END

- }

- $code .= <<END;

+ if (!impl->toNode())

+ ${hiddenDependencyAction}HiddenDependency(args.Holder(), args[1], ${v8ClassName}::eventListenerCacheIndex, args.GetIsolate());

}