Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(27)

Issue 18539: Loads and unloads .so files. (Closed)

Created:
10 years, 6 months ago by Evan Martin
Modified:
8 years, 2 months ago
Reviewers:
jam, agl
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux plugin loader loads and unloads .so files.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -5 lines) Patch
M webkit/glue/plugins/plugin_lib_linux.cc View 3 chunks +44 lines, -5 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Evan Martin
10 years, 6 months ago (2009-01-23 01:41:40 UTC) #1
Evan Martin
10 years, 6 months ago (2009-01-23 01:41:58 UTC) #2
agl
LGTM
10 years, 6 months ago (2009-01-23 01:44:38 UTC) #3
jam
10 years, 6 months ago (2009-01-23 01:54:10 UTC) #4
http://codereview.chromium.org/18539/diff/1/2
File webkit/glue/plugins/plugin_lib_linux.cc (right):

http://codereview.chromium.org/18539/diff/1/2#newcode66
Line 66: UnloadNativeLibrary(dl);
I'm not sure you want to do this.  On Windows at least, some NPAPI plugins such
as Java also expose XPCOM functionality.  You wouldn't want to unload them just
because they do.

Powered by Google App Engine
This is Rietveld 408576698