Issue 18539: Loads and unloads .so files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18539: Loads and unloads .so files. (Closed)

Created:
11 years, 11 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
jam, agl

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Linux plugin loader loads and unloads .so files.

Patch Set 1 #

Total comments: 1

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -5 lines)			Patch
	M	webkit/glue/plugins/plugin_lib_linux.cc	View		3 chunks	+44 lines, -5 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jam

11 years, 11 months ago (2009-01-23 01:54:10 UTC) #4

http://codereview.chromium.org/18539/diff/1/2
File webkit/glue/plugins/plugin_lib_linux.cc (right):

http://codereview.chromium.org/18539/diff/1/2#newcode66
Line 66: UnloadNativeLibrary(dl);
I'm not sure you want to do this.  On Windows at least, some NPAPI plugins such
as Java also expose XPCOM functionality.  You wouldn't want to unload them just
because they do.

Expand Messages | Collapse Messages