Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1853833002: Added a test for success after one backoff (Closed)

Created:
4 years, 8 months ago by vakh (use Gerrit instead)
Modified:
4 years, 8 months ago
Reviewers:
Nathan Parker
CC:
chromium-reviews, awoz, kcarattini
Base URL:
https://chromium.googlesource.com/chromium/src.git@v4_02_init_update
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added a test for success after one backoff BUG=543161 Committed: https://crrev.com/b743db0679fcd80689e7d6ebdde1b972f12a3738 Cr-Commit-Position: refs/heads/master@{#384765}

Patch Set 1 #

Total comments: 2

Patch Set 2 : git fetch && pull && bring back checks for update_error_count_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -3 lines) Patch
M components/safe_browsing_db/v4_update_protocol_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/safe_browsing_db/v4_update_protocol_manager_unittest.cc View 1 7 chunks +73 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
vakh (use Gerrit instead)
4 years, 8 months ago (2016-04-01 17:33:57 UTC) #2
Nathan Parker
lgtm https://codereview.chromium.org/1853833002/diff/1/components/safe_browsing_db/v4_update_protocol_manager_unittest.cc File components/safe_browsing_db/v4_update_protocol_manager_unittest.cc (right): https://codereview.chromium.org/1853833002/diff/1/components/safe_browsing_db/v4_update_protocol_manager_unittest.cc#newcode270 components/safe_browsing_db/v4_update_protocol_manager_unittest.cc:270: EXPECT_TRUE(pm->IsUpdateScheduled()); Why remove the checks of pm->update_*
4 years, 8 months ago (2016-04-01 23:10:10 UTC) #3
vakh (use Gerrit instead)
https://codereview.chromium.org/1853833002/diff/1/components/safe_browsing_db/v4_update_protocol_manager_unittest.cc File components/safe_browsing_db/v4_update_protocol_manager_unittest.cc (right): https://codereview.chromium.org/1853833002/diff/1/components/safe_browsing_db/v4_update_protocol_manager_unittest.cc#newcode270 components/safe_browsing_db/v4_update_protocol_manager_unittest.cc:270: EXPECT_TRUE(pm->IsUpdateScheduled()); On 2016/04/01 23:10:10, Nathan Parker wrote: > Why ...
4 years, 8 months ago (2016-04-01 23:13:23 UTC) #4
vakh (use Gerrit instead)
git fetch && pull && bring back checks for update_error_count_
4 years, 8 months ago (2016-04-02 00:09:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853833002/20001
4 years, 8 months ago (2016-04-02 00:10:45 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-02 01:06:46 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-02 01:08:51 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b743db0679fcd80689e7d6ebdde1b972f12a3738
Cr-Commit-Position: refs/heads/master@{#384765}

Powered by Google App Engine
This is Rietveld 408576698