Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1853823002: Revert of Switch SkDownSampleImageFilter over to new onFilterImage interface (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Switch SkDownSampleImageFilter over to new onFilterImage interface (patchset #2 id:20001 of https://codereview.chromium.org/1851583002/ ) Reason for revert: Some images are incorrect Original issue's description: > Switch SkDownSampleImageFilter over to new onFilterImage interface > > This will slightly change the testimagefilters GM images > > TBR=reed@google.com > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1851583002 > > Committed: https://skia.googlesource.com/skia/+/daa9da4937b6dfc9e1047239b4afd41b1c5474d5 TBR=senorblanco@chromium.org,reed@google.com,senorblanco@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/4eb4964e1802d6f222c47e9158636e1ae80bb4b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -41 lines) Patch
M include/effects/SkTestImageFilters.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/effects/SkTestImageFilters.cpp View 2 chunks +41 lines, -38 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
robertphillips
Created Revert of Switch SkDownSampleImageFilter over to new onFilterImage interface
4 years, 8 months ago (2016-04-01 15:09:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853823002/1
4 years, 8 months ago (2016-04-01 15:09:39 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 15:09:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4eb4964e1802d6f222c47e9158636e1ae80bb4b7

Powered by Google App Engine
This is Rietveld 408576698