Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1853803003: Fix padding bug in SkTileImageFilter. (Closed)

Created:
4 years, 8 months ago by Stephen White
Modified:
4 years, 8 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix padding bug in SkTileImageFilter. When padding an image out to tile size, use the filter input, not the source primitive. NOTE: this will affect the tileimagefilter GM (new test case & size). R=robertphillips@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1853803003 Committed: https://skia.googlesource.com/skia/+/f27002947d40ab884e13d39ee2ef0ac4ccadcd6a

Patch Set 1 #

Patch Set 2 : Add GM #

Patch Set 3 : Win32 fix (and simplification) #

Total comments: 1

Patch Set 4 : Fix overlength lines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M gm/tileimagefilter.cpp View 1 2 3 2 chunks +15 lines, -1 line 0 comments Download
M src/effects/SkTileImageFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Stephen White
Rob: PTAL. Thanks!
4 years, 8 months ago (2016-04-01 15:38:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853803003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853803003/20001
4 years, 8 months ago (2016-04-01 15:41:00 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/7562)
4 years, 8 months ago (2016-04-01 15:43:31 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853803003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853803003/40001
4 years, 8 months ago (2016-04-01 15:46:51 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-01 15:57:41 UTC) #10
robertphillips
lgtm https://codereview.chromium.org/1853803003/diff/40001/gm/tileimagefilter.cpp File gm/tileimagefilter.cpp (right): https://codereview.chromium.org/1853803003/diff/40001/gm/tileimagefilter.cpp#newcode115 gm/tileimagefilter.cpp:115: SkImageFilter::CropRect cropRect(SkRect::MakeXYWH(5, 5, 40, 40)); overlength
4 years, 8 months ago (2016-04-01 16:08:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853803003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853803003/60001
4 years, 8 months ago (2016-04-01 16:10:10 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 16:25:03 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/f27002947d40ab884e13d39ee2ef0ac4ccadcd6a

Powered by Google App Engine
This is Rietveld 408576698