Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 1853793002: Prepare to remove webrtc::MediaStreamTrackInterface::set_state (Closed)

Created:
4 years, 8 months ago by perkj_chrome
Modified:
4 years, 8 months ago
Reviewers:
Guido Urdaneta
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare to remove webrtc::MediaStreamTrackInterface::set_state This removes the use of webrtc::MediaStreamTrackInterface::set_state and instead cleanup the Mock audio and video tracks and adds SetState on those. Only affects unittests. BUG=webrtc:5426 Committed: https://crrev.com/a07760d5ebd5a3deb5d08794942539e3741d040f Cr-Commit-Position: refs/heads/master@{#385168}

Patch Set 1 #

Patch Set 2 : NON_EXPORTED_BASE #

Patch Set 3 : ... #

Patch Set 4 : Make mocks implement pure interface #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -40 lines) Patch
M content/renderer/media/rtc_peer_connection_handler_unittest.cc View 2 chunks +6 lines, -12 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/webrtc/mock_peer_connection_dependency_factory.h View 1 2 3 4 3 chunks +41 lines, -12 lines 0 comments Download
M content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc View 1 2 3 4 chunks +73 lines, -14 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
perkj_chrome
Please?
4 years, 8 months ago (2016-04-01 14:10:07 UTC) #2
Guido Urdaneta
lgtm
4 years, 8 months ago (2016-04-01 14:22:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853793002/1
4 years, 8 months ago (2016-04-01 14:23:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/167864)
4 years, 8 months ago (2016-04-01 16:05:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853793002/1
4 years, 8 months ago (2016-04-04 06:52:46 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/168602)
4 years, 8 months ago (2016-04-04 08:44:29 UTC) #11
perkj_chrome
Guido - can you do a new review? I changed the mocks to implement the ...
4 years, 8 months ago (2016-04-05 13:16:09 UTC) #12
Guido Urdaneta
still lgtm
4 years, 8 months ago (2016-04-05 13:29:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853793002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853793002/80001
4 years, 8 months ago (2016-04-05 13:30:09 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-05 14:35:13 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 14:36:51 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/a07760d5ebd5a3deb5d08794942539e3741d040f
Cr-Commit-Position: refs/heads/master@{#385168}

Powered by Google App Engine
This is Rietveld 408576698