Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: test/cctest/heap/test-heap.cc

Issue 1853783002: [heap] Non-contiguous young generation (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Hannes comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/spaces-inl.h ('k') | test/cctest/heap/test-spaces.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/heap/test-heap.cc
diff --git a/test/cctest/heap/test-heap.cc b/test/cctest/heap/test-heap.cc
index a381950757830cddb65da624307b8cc022936f9f..0e85928a310dc590c07b06bbb41f14dbe15588d7 100644
--- a/test/cctest/heap/test-heap.cc
+++ b/test/cctest/heap/test-heap.cc
@@ -2333,11 +2333,7 @@ TEST(GrowAndShrinkNewSpace) {
Heap* heap = CcTest::heap();
NewSpace* new_space = heap->new_space();
- if (heap->ReservedSemiSpaceSize() == heap->InitialSemiSpaceSize() ||
- heap->MaxSemiSpaceSize() == heap->InitialSemiSpaceSize()) {
- // The max size cannot exceed the reserved size, since semispaces must be
- // always within the reserved space. We can't test new space growing and
- // shrinking if the reserved size is the same as the minimum (initial) size.
+ if (heap->MaxSemiSpaceSize() == heap->InitialSemiSpaceSize()) {
return;
}
@@ -2382,11 +2378,7 @@ TEST(GrowAndShrinkNewSpace) {
TEST(CollectingAllAvailableGarbageShrinksNewSpace) {
CcTest::InitializeVM();
Heap* heap = CcTest::heap();
- if (heap->ReservedSemiSpaceSize() == heap->InitialSemiSpaceSize() ||
- heap->MaxSemiSpaceSize() == heap->InitialSemiSpaceSize()) {
- // The max size cannot exceed the reserved size, since semispaces must be
- // always within the reserved space. We can't test new space growing and
- // shrinking if the reserved size is the same as the minimum (initial) size.
+ if (heap->MaxSemiSpaceSize() == heap->InitialSemiSpaceSize()) {
return;
}
« no previous file with comments | « src/heap/spaces-inl.h ('k') | test/cctest/heap/test-spaces.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698