Certificate Transparency: New component for obtaining fresh STHs.

chrome/browser/chromeos/login/session/user_session_manager.cc

Index: chrome/browser/chromeos/login/session/user_session_manager.cc
diff --git a/chrome/browser/chromeos/login/session/user_session_manager.cc b/chrome/browser/chromeos/login/session/user_session_manager.cc
index 2a75b4c8aef62530e7686c4c6fd260ac31a4055b..85dccc0c520d7032f18a6527bcfbf9941b71444c 100644
--- a/chrome/browser/chromeos/login/session/user_session_manager.cc
+++ b/chrome/browser/chromeos/login/session/user_session_manager.cc
@@ -60,6 +60,7 @@
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/component_updater/ev_whitelist_component_installer.h"
+#include "chrome/browser/component_updater/sth_set_component_installer.h"
 #include "chrome/browser/first_run/first_run.h"
 #include "chrome/browser/google/google_brand_chromeos.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
@@ -1148,7 +1149,7 @@ void UserSessionManager::FinalizePrepareProfile(Profile* profile) {
     InitRlz(profile);
     InitializeCerts(profile);
     InitializeCRLSetFetcher(user);
-    InitializeEVCertificatesWhitelistComponent(user);
+    InitializeCertificateTransparencyRelatedComponents(user);

[Sorin Jianu, 2016/04/04 22:06:13]

Is Related affix needed?
Why not say just InitializeCertificateTransparencyComponents ?

[Eran Messeri, 2016/04/05 15:34:06]

Done.

 
     if (arc::ArcBridgeService::GetEnabled(
             base::CommandLine::ForCurrentProcess())) {
@@ -1415,7 +1416,7 @@ void UserSessionManager::InitializeCRLSetFetcher(
   }
 }
 
-void UserSessionManager::InitializeEVCertificatesWhitelistComponent(
+void UserSessionManager::InitializeCertificateTransparencyRelatedComponents(
     const user_manager::User* user) {
   const std::string username_hash = user->username_hash();
   component_updater::ComponentUpdateService* cus =
@@ -1423,7 +1424,15 @@ void UserSessionManager::InitializeEVCertificatesWhitelistComponent(
   if (!username_hash.empty() && cus) {
     const base::FilePath path =
         ProfileHelper::GetProfilePathByUserIdHash(username_hash);
+    // EV whitelist
     RegisterEVWhitelistComponent(cus, path);
+
+    // TODO(eranm): Pass the distributor to the IOThread so CT
+    // TreeStateTracker instances can register for STH updates.
+    scoped_ptr<net::ct::STHDistributor> distributor(
+        new net::ct::STHDistributor());
+    // STH set fetcher.
+    RegisterSTHSetComponent(cus, path, std::move(distributor));

[Sorin Jianu, 2016/04/04 22:06:13]

Related to the other comments, if would be nice is the code is like this:

// EV whitelist
RegisterEVWhitelistComponent(cus, path);

// STH set fetcher.
RegisterSTHSetComponent(cus, path);

and we deal with the |distributor| inside the RegisterSTHSetComponent.

[Eran Messeri, 2016/04/05 15:34:06]

See comment in chrome_browser_main - that distributor has to get to the IOThread
somehow...

   }
 }