components/component_updater/default_component_installer.cc - Issue 1853753003: Certificate Transparency: New component for obtaining fresh STHs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/component_updater/default_component_installer.cc

Issue 1853753003: Certificate Transparency: New component for obtaining fresh STHs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments by sorin & waffles Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/component_updater/sth_set_component_installer_unittest.cc ('K') | « components/component_updater/component_updater_paths.cc ('k') | net/cert/sth_distributor.h » ('j') | net/cert/sth_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/component_updater/default_component_installer.cc

diff --git a/components/component_updater/default_component_installer.cc b/components/component_updater/default_component_installer.cc

index 8f5bba6b6a2f44f4d46b87da85fdbe8916da7852..cb40ea2328e5f0a8ea558e6f3036a8d2c2b7f86d 100644

--- a/components/component_updater/default_component_installer.cc

+++ b/components/component_updater/default_component_installer.cc

@@ -286,7 +286,8 @@ void DefaultComponentInstaller::FinishRegistration(

void DefaultComponentInstaller::ComponentReady(

scoped_ptr<base::DictionaryValue> manifest) {

- VLOG(1) << "ComponentReady";

+ VLOG(1) << "Component ready, version " << current_version_.GetString()

+ << " in " << GetInstallDirectory().value();

installer_traits_->ComponentReady(current_version_, GetInstallDirectory(),

std::move(manifest));

}