Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp

Issue 1853743005: Oilpan: Remove WillBe types (part 13) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp
diff --git a/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp b/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp
index c5b8395c59dd1caeb7e337138dfe8b6fdef8366c..db4b432e497b4665ab12a9d709ccc018a65d829d 100644
--- a/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp
+++ b/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp
@@ -21,12 +21,12 @@
namespace blink {
-class MockLinkLoaderClient final : public NoBaseWillBeGarbageCollectedFinalized<MockLinkLoaderClient>, public LinkLoaderClient {
- WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MockLinkLoaderClient);
+class MockLinkLoaderClient final : public GarbageCollectedFinalized<MockLinkLoaderClient>, public LinkLoaderClient {
+ USING_GARBAGE_COLLECTED_MIXIN(MockLinkLoaderClient);
public:
- static PassOwnPtrWillBeRawPtr<MockLinkLoaderClient> create(bool shouldLoad)
+ static RawPtr<MockLinkLoaderClient> create(bool shouldLoad)
{
- return adoptPtrWillBeNoop(new MockLinkLoaderClient(shouldLoad));
+ return new MockLinkLoaderClient(shouldLoad);
}
DEFINE_INLINE_VIRTUAL_TRACE() { LinkLoaderClient::trace(visitor); }
@@ -138,8 +138,8 @@ TEST(LinkLoaderTest, Preload)
for (const auto& testCase : cases) {
OwnPtr<DummyPageHolder> dummyPageHolder = DummyPageHolder::create(IntSize(500, 500));
dummyPageHolder->frame().settings()->setScriptEnabled(true);
- OwnPtrWillBePersistent<MockLinkLoaderClient> loaderClient = MockLinkLoaderClient::create(testCase.linkLoaderShouldLoadValue);
- OwnPtrWillBeRawPtr<LinkLoader> loader = LinkLoader::create(loaderClient.get());
+ Persistent<MockLinkLoaderClient> loaderClient = MockLinkLoaderClient::create(testCase.linkLoaderShouldLoadValue);
+ RawPtr<LinkLoader> loader = LinkLoader::create(loaderClient.get());
KURL hrefURL = KURL(KURL(), testCase.href);
URLTestHelpers::registerMockedErrorURLLoad(hrefURL);
loader->loadLink(LinkRelAttribute("preload"),
@@ -151,7 +151,7 @@ TEST(LinkLoaderTest, Preload)
dummyPageHolder->document(),
NetworkHintsMock());
ASSERT(dummyPageHolder->document().fetcher());
- WillBeHeapListHashSet<RefPtrWillBeMember<Resource>>* preloads = dummyPageHolder->document().fetcher()->preloads();
+ HeapListHashSet<Member<Resource>>* preloads = dummyPageHolder->document().fetcher()->preloads();
if (testCase.expectingLoad) {
if (!preloads)
fprintf(stderr, "Unexpected result %s %s %s\n", testCase.href, testCase.as, testCase.type);
@@ -195,8 +195,8 @@ TEST(LinkLoaderTest, DNSPrefetch)
for (const auto& testCase : cases) {
OwnPtr<DummyPageHolder> dummyPageHolder = DummyPageHolder::create(IntSize(500, 500));
dummyPageHolder->document().settings()->setDNSPrefetchingEnabled(true);
- OwnPtrWillBePersistent<MockLinkLoaderClient> loaderClient = MockLinkLoaderClient::create(testCase.shouldLoad);
- OwnPtrWillBeRawPtr<LinkLoader> loader = LinkLoader::create(loaderClient.get());
+ Persistent<MockLinkLoaderClient> loaderClient = MockLinkLoaderClient::create(testCase.shouldLoad);
+ RawPtr<LinkLoader> loader = LinkLoader::create(loaderClient.get());
KURL hrefURL = KURL(KURL(ParsedURLStringTag(), String("http://example.com")), testCase.href);
NetworkHintsMock networkHints;
loader->loadLink(LinkRelAttribute("dns-prefetch"),
@@ -230,8 +230,8 @@ TEST(LinkLoaderTest, Preconnect)
// Test the cases with a single header
for (const auto& testCase : cases) {
OwnPtr<DummyPageHolder> dummyPageHolder = DummyPageHolder::create(IntSize(500, 500));
- OwnPtrWillBePersistent<MockLinkLoaderClient> loaderClient = MockLinkLoaderClient::create(testCase.shouldLoad);
- OwnPtrWillBeRawPtr<LinkLoader> loader = LinkLoader::create(loaderClient.get());
+ Persistent<MockLinkLoaderClient> loaderClient = MockLinkLoaderClient::create(testCase.shouldLoad);
+ RawPtr<LinkLoader> loader = LinkLoader::create(loaderClient.get());
KURL hrefURL = KURL(KURL(ParsedURLStringTag(), String("http://example.com")), testCase.href);
NetworkHintsMock networkHints;
loader->loadLink(LinkRelAttribute("preconnect"),

Powered by Google App Engine
This is Rietveld 408576698