Remove platform_video_capturing_mac and the callback thread checker in VideoCaptureDeviceAVFoundati…

Remove platform_video_capturing_mac and the callback thread checker in VideoCaptureDeviceAVFoundation

PlatformVideoCapturingMac is an interface used by
VideoCaptureDeviceMac and implemented by the defunct
VideoCaptureDeviceQTKit and VideoCaptureDeviceAVFoundation.
Since this abstraction is not needed anymore, remove it.
(FTR, an Obj-C |protocol| is sort of a base abstract class
in C++).

Also with https://crrev.com/1815983003, the thread checker
|callback_thread_checker_| is not needed anymore since the
code path to -setCaptureHeight:width:frameRate from that
thread is gone, and we cannot make assumptions as to the
thread on which the OS call with the captured frames.

BUG=589096, 578277
TEST= all Mac capture working fine.

Committed: https://crrev.com/586aca8418b6cd7889e8f29f08bae7317eebc347
Cr-Commit-Position: refs/heads/master@{#384913}

[mcasas, 2016-04-01 18:15:06]

mcasas@chromium.org changed reviewers:
+ olka@chromium.org, rsesek@chromium.org

[mcasas, 2016-04-01 18:15:07]

rsesek@ PTAL at the Obj-C parts 

olka@: PTAL at the thread checker removal.

[Robert Sesek, 2016-04-01 18:56:10]

LGTM

https://codereview.chromium.org/1853743003/diff/1/media/capture/video/mac/vid...
File media/capture/video/mac/video_capture_device_avfoundation_mac.mm (right):

https://codereview.chromium.org/1853743003/diff/1/media/capture/video/mac/vid...
media/capture/video/mac/video_capture_device_avfoundation_mac.mm:354: 
nit: remove extra blank line

[mcasas, 2016-04-01 22:02:14]

Description was changed from

==========
Remove platform_video_capturing_mac and the callback thread checker in
VideoCaptureDeviceAVFoundation

PlatformVideoCapturingMac is an interface used by
VideoCaptureDeviceMac and implemented by the defunct
VideoCaptureDeviceQTKit and VideoCaptureDeviceAVFoundation.
Since this abstraction is not needed anymore, remove it.
(FTR, an Obj-C |protocol| is sort of a base abstract class
in C++).

Also with https://crrev.com/1815983003, the thread checker
|callback_thread_checker_| is not needed anymore since the
code path to -setCaptureHeight:width:frameRate from that
thread is gone, and we cannot make assumptions as to the
thread on which the OS call with the captured frames.



BUG=589096
TEST= all Mac capture working fine.
==========

to

==========
Remove platform_video_capturing_mac and the callback thread checker in
VideoCaptureDeviceAVFoundation

PlatformVideoCapturingMac is an interface used by
VideoCaptureDeviceMac and implemented by the defunct
VideoCaptureDeviceQTKit and VideoCaptureDeviceAVFoundation.
Since this abstraction is not needed anymore, remove it.
(FTR, an Obj-C |protocol| is sort of a base abstract class
in C++).

Also with https://crrev.com/1815983003, the thread checker
|callback_thread_checker_| is not needed anymore since the
code path to -setCaptureHeight:width:frameRate from that
thread is gone, and we cannot make assumptions as to the
thread on which the OS call with the captured frames.



BUG=589096, 578277
TEST= all Mac capture working fine.
==========

[mcasas, 2016-04-01 22:08:17]

o1ka@ PTAL

https://codereview.chromium.org/1853743003/diff/1/media/capture/video/mac/vid...
File media/capture/video/mac/video_capture_device_avfoundation_mac.mm (right):

https://codereview.chromium.org/1853743003/diff/1/media/capture/video/mac/vid...
media/capture/video/mac/video_capture_device_avfoundation_mac.mm:354: 
On 2016/04/01 18:56:09, Robert Sesek wrote:
> nit: remove extra blank line

Done.

[mcasas, 2016-04-01 22:08:55]

mcasas@chromium.org changed reviewers:
+ sandersd@chromium.org

[mcasas, 2016-04-01 22:08:56]

sandersd@: RS removing the one file from gyp/gns plz.

[sandersd (OOO until July 31), 2016-04-01 23:49:19]

lgtm

[o1ka, 2016-04-04 13:20:05]

lgtm thread checker removal

[mcasas, 2016-04-04 14:11:57]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-04-04 14:11:58]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/1853743003/#ps20001
(title: "removed extra line")

[commit-bot: I haz the power, 2016-04-04 14:12:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1853743003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1853743003/20001

[commit-bot: I haz the power, 2016-04-04 15:33:17]

Description was changed from

==========
Remove platform_video_capturing_mac and the callback thread checker in
VideoCaptureDeviceAVFoundation

PlatformVideoCapturingMac is an interface used by
VideoCaptureDeviceMac and implemented by the defunct
VideoCaptureDeviceQTKit and VideoCaptureDeviceAVFoundation.
Since this abstraction is not needed anymore, remove it.
(FTR, an Obj-C |protocol| is sort of a base abstract class
in C++).

Also with https://crrev.com/1815983003, the thread checker
|callback_thread_checker_| is not needed anymore since the
code path to -setCaptureHeight:width:frameRate from that
thread is gone, and we cannot make assumptions as to the
thread on which the OS call with the captured frames.



BUG=589096, 578277
TEST= all Mac capture working fine.
==========

to

==========
Remove platform_video_capturing_mac and the callback thread checker in
VideoCaptureDeviceAVFoundation

PlatformVideoCapturingMac is an interface used by
VideoCaptureDeviceMac and implemented by the defunct
VideoCaptureDeviceQTKit and VideoCaptureDeviceAVFoundation.
Since this abstraction is not needed anymore, remove it.
(FTR, an Obj-C |protocol| is sort of a base abstract class
in C++).

Also with https://crrev.com/1815983003, the thread checker
|callback_thread_checker_| is not needed anymore since the
code path to -setCaptureHeight:width:frameRate from that
thread is gone, and we cannot make assumptions as to the
thread on which the OS call with the captured frames.



BUG=589096, 578277
TEST= all Mac capture working fine.
==========

[commit-bot: I haz the power, 2016-04-04 15:33:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-04 15:36:04]

Description was changed from

==========
Remove platform_video_capturing_mac and the callback thread checker in
VideoCaptureDeviceAVFoundation

PlatformVideoCapturingMac is an interface used by
VideoCaptureDeviceMac and implemented by the defunct
VideoCaptureDeviceQTKit and VideoCaptureDeviceAVFoundation.
Since this abstraction is not needed anymore, remove it.
(FTR, an Obj-C |protocol| is sort of a base abstract class
in C++).

Also with https://crrev.com/1815983003, the thread checker
|callback_thread_checker_| is not needed anymore since the
code path to -setCaptureHeight:width:frameRate from that
thread is gone, and we cannot make assumptions as to the
thread on which the OS call with the captured frames.



BUG=589096, 578277
TEST= all Mac capture working fine.
==========

to

==========
Remove platform_video_capturing_mac and the callback thread checker in
VideoCaptureDeviceAVFoundation

PlatformVideoCapturingMac is an interface used by
VideoCaptureDeviceMac and implemented by the defunct
VideoCaptureDeviceQTKit and VideoCaptureDeviceAVFoundation.
Since this abstraction is not needed anymore, remove it.
(FTR, an Obj-C |protocol| is sort of a base abstract class
in C++).

Also with https://crrev.com/1815983003, the thread checker
|callback_thread_checker_| is not needed anymore since the
code path to -setCaptureHeight:width:frameRate from that
thread is gone, and we cannot make assumptions as to the
thread on which the OS call with the captured frames.

BUG=589096, 578277
TEST= all Mac capture working fine.

Committed: https://crrev.com/586aca8418b6cd7889e8f29f08bae7317eebc347
Cr-Commit-Position: refs/heads/master@{#384913}
==========

[commit-bot: I haz the power, 2016-04-04 15:36:05]

Patchset 2 (id:??) landed as
https://crrev.com/586aca8418b6cd7889e8f29f08bae7317eebc347
Cr-Commit-Position: refs/heads/master@{#384913}