Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1853713004: mac: Remove some 10.6-SDK-only sandbox code. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, eugenis+clang_chromium.org, yunlian, rickyz+watch_chromium.org, glider+clang_chromium.org, ukai+watch_chromium.org, dmikurube+clang_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Remove some 10.6-SDK-only sandbox code. BUG=579255 Committed: https://crrev.com/3e4b28bd7389115569a7f70c945269e6aa6a5253 Cr-Commit-Position: refs/heads/master@{#384690}

Patch Set 1 #

Patch Set 2 : sigh #

Patch Set 3 : . #

Patch Set 4 : bleh #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Total comments: 2

Patch Set 8 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -321 lines) Patch
M sandbox/mac/BUILD.gn View 3 chunks +0 lines, -49 lines 0 comments Download
M sandbox/mac/bootstrap_sandbox_unittest.mm View 7 chunks +0 lines, -17 lines 0 comments Download
M sandbox/mac/os_compatibility.cc View 1 2 3 4 5 6 7 7 chunks +10 lines, -31 lines 0 comments Download
M sandbox/mac/sandbox_mac.gypi View 2 chunks +0 lines, -47 lines 0 comments Download
M sandbox/mac/xpc.h View 1 2 3 1 chunk +48 lines, -26 lines 0 comments Download
D sandbox/mac/xpc.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M sandbox/mac/xpc_message_server.cc View 1 chunk +1 line, -3 lines 0 comments Download
M sandbox/mac/xpc_message_server_unittest.cc View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
D sandbox/mac/xpc_private_stubs.sig View 1 chunk +0 lines, -22 lines 0 comments Download
D sandbox/mac/xpc_stubs.sig View 1 chunk +0 lines, -20 lines 0 comments Download
D sandbox/mac/xpc_stubs_header.fragment View 1 chunk +0 lines, -78 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Nico
4 years, 8 months ago (2016-04-01 19:53:02 UTC) #3
Robert Sesek
LGTM https://codereview.chromium.org/1853713004/diff/120001/sandbox/mac/os_compatibility.cc File sandbox/mac/os_compatibility.cc (left): https://codereview.chromium.org/1853713004/diff/120001/sandbox/mac/os_compatibility.cc#oldcode20 sandbox/mac/os_compatibility.cc:20: // Verified from launchd-329.3.3 (10.6.8). Can you keep ...
4 years, 8 months ago (2016-04-01 20:00:55 UTC) #4
Nico
https://codereview.chromium.org/1853713004/diff/120001/sandbox/mac/os_compatibility.cc File sandbox/mac/os_compatibility.cc (left): https://codereview.chromium.org/1853713004/diff/120001/sandbox/mac/os_compatibility.cc#oldcode20 sandbox/mac/os_compatibility.cc:20: // Verified from launchd-329.3.3 (10.6.8). On 2016/04/01 20:00:55, Robert ...
4 years, 8 months ago (2016-04-01 20:05:04 UTC) #5
Robert Sesek
lgtm
4 years, 8 months ago (2016-04-01 20:06:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853713004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853713004/140001
4 years, 8 months ago (2016-04-01 20:06:21 UTC) #9
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 8 months ago (2016-04-01 21:16:04 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 21:17:29 UTC) #13
Message was sent while issue was closed. 
Patchset 8 (id:??) landed as
https://crrev.com/3e4b28bd7389115569a7f70c945269e6aa6a5253
Cr-Commit-Position: refs/heads/master@{#384690}

Powered by Google App Engine
This is Rietveld 408576698