Issue 18536005: bookmarks: Change BookmarkExpandedStateTracker to take PrefService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18536005: bookmarks: Change BookmarkExpandedStateTracker to take PrefService. (Closed)

Created:
7 years, 5 months ago by tfarina

Modified:
7 years, 5 months ago

Reviewers:
sky

CC:
chromium-reviews, browser-components-watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

bookmarks: Change BookmarkExpandedStateTracker to take PrefService. It just need PrefService instead of BrowserContext. This is a good thing per Law of Demeter. BUG=144783 TEST=unit_tests --gtest_filter=BookmarkExpandedStateTrackerTest.* R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211754

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -24 lines)			Patch
M	chrome/browser/bookmarks/bookmark_expanded_state_tracker.h	View	3 chunks	+7 lines, -10 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_expanded_state_tracker.cc	View	4 chunks	+9 lines, -11 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/18536005/1

7 years, 5 months ago (2013-07-15 23:37:05 UTC) #3

tfarina

7 years, 5 months ago (2013-07-16 03:05:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r211754 (presubmit successful).